Bugzilla – Bug 1852
Ctrl+M does not open label for editing
Last modified: 2018-08-20 11:51:25 UTC
If a label is added with Ctrl+M, the label is not open for editing, so typing text intended for the label does not get entered in the label. This slows down the process of adding labels, but more dangerously will cause a recording to stop if the typed text, intended for the label, includes as space. Regression on 2.2.1. The ability to add a textless label with one key press does have some benefit for some use cases, but is a big negative for others, so if we wish to retain the current behaviour, it should be a (non-default) option.
The most serious issue her is that the user can easily type a space as part of their supposed label text (they may be poor touch typists like me and be looking at keyboard rather than screen - or thy may be VI users). Typing space like that will cause the recording to stop and thus the user may lose data by missing an unrepeatable recording. If this bug remains at P2 (it is borderline P1 IMO) then I do not think we can release 2.3.0 with this as an extant bug - for me it is a must-fix
(In reply to Steve Daulton from comment #0) > If a label is added with Ctrl+M, the label is not open for editing, so > typing text intended for the label does not get entered in the label. > > This slows down the process of adding labels, but more dangerously will > cause a recording to stop if the typed text, intended for the label, > includes as space. or the letters p or x. > > Regression on 2.2.1. > > The ability to add a textless label with one key press does have some > benefit for some use cases, but is a big negative for others, so if we wish > to retain the current behaviour, it should be a (non-default) option.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/2cb76e082071668102259a45dffedc3a811bdcf9
Note: Ctrl+M isn't in the shortcuts for Mac. Mac uses Cmd+B. This doesn't appear to be a problem on MacOS 10.12.6 on Audacity 2.2.2 and checks still ok on Audacity 2.3.0 built this evening. Using Cmd+B the focus changes to the Label track so typing Space or P or X isn't an issue since the track is not selected during recording unless done manually. Manually selecting the track during recording then cmd+B to create a label track and a label, the label track still takes the focus so typing in contents works properly even on 2.2.2 during recording.
(In reply to James Crook from comment #3) Tested on W10 2018-03-17 (build 88) and on Macbook Pro 10.13.3 audacity-macos-nightly-2.3.0-bc6ed77.dmg - 28.48 MB | version: 2.3.0--17Mar18 Tests fine on both platforms note that on Mac the Ctrl+M equicalent is Cmd + . (period) Focus remains on the newly created label at the playback/recording position enabling text to be typed in - and *not* sending shortcuts to Audacity.
