Bug 1861 – SplitLabels command fails in Macros

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1861 - SplitLabels command fails in Macros


Summary:	SplitLabels command fails in Macros

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Other
Version:	2.3.0
Hardware:	Per OS All

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-03-27 11:24 UTC by Peter Sampson
Modified:	2018-08-20 11:45 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1) import the attached Macro by adding the .txt file to you Macros folder 2) get some audio that starts at T=0 with 1.5 second silence starting at 1 second 3) run the Macro 4) Error message:Your batch command of Label Split(SplitLabels) was not recognized 5) However run the Macro a second time and it will work - but with double labels for the silence(s)
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Macro file - SplitLabels fails (165 bytes, text/plain) 2018-03-27 11:24 UTC, Peter Sampson	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2018-03-27 11:24:31 UTC

Created attachment 752 [details]
Macro file - SplitLabels fails

This Macro fails at the SplitLabels command

SelectAll:
SilenceFinder:labelbeforedur="0.3" sil-dur="1" sil-lev="26"
SelectAll:
SplitLabels:
SelectAll:
CursProjectStart:
SelNextClip:
Delete:
ExportWav:


James wrote:
Actually it is a bug with the enabled flags for macro commands.
When you start the macro the SplitLabels is disabled, because there are no labels selected (and no track).  You can see that in the menu.
And it never updates, until you finish the macro.

That bug probably has always been there, just never noticed until now.



James provided a workaround:
Add Extra Menus (on/off)  TWICE immediately before the Label Split (SplitLabels) command.
That causes the menus and their flags to be regenerated.  And then the command will work because the command is not greyed out in the menus anymore after the greying-out flags are re calculated!

Comment 1 James Crook 2018-03-27 15:36:08 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/b92e334873ea0c22e15d4854f7797a6a567476d2

Comment 2 Cliff Scott 2018-03-27 23:22:43 UTC

No crash on build 6228b6 built this evening. MacOS 10.12.6. Project ended with 1.5 seconds of silence and an empty label track. Export file and directory dialog came up and was canceled.

Comment 3 Peter Sampson 2018-03-30 05:23:08 UTC

Tested on James build audacity 2.3.0jc001 on W10 this now works prtoperly with no errors - so based on this and Cliff's test on Mac I shall close this off as resolved.