Bug 1895 – pin/unpin button inconsistent in Punch and Roll Recording

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1895 - pin/unpin button inconsistent in Punch and Roll Recording


Summary:	pin/unpin button inconsistent in Punch and Roll Recording

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.0
Hardware:	Per OS Other

Importance:	P5 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-07-01 05:05 UTC by Peter Sampson
Modified:	2018-08-20 11:51 UTC (History)
CC List:	3 users (show)

See Also:
Steps To Reproduce:	1) use Punch & Roll t o repair some audio 2) observe the pin/unpin button
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2018-07-01 05:05:04 UTC

This recent commit:  Show Pin/Unpin button in red, if recording
https://github.com/audacity/audacity/commit/356fdeba406580fb3b6508123b52947bd27655c3
Is fine when used in normal recording.


But when using Punch and Roll the pin/unpin button goes red as soon as you hit the Shift+D - i.e. it is red for the default 5 seconds of pre-roll playback.

Contrast this with what Paul does for the playhead/recordhead
a) during Pre-roll playback the head is green (i.e, playhead)
b) once the punch rolling record starts the head changes to red (i.e. recordhead)

So it does look (and is) inconsistent.

Comment 1 Peter Sampson 2018-08-11 09:39:56 UTC

Testing on W10 with needs updating as the Pinned/unpinned head option has been removed in favor of the icon on the ruler.

This is now fixed - the pin and the icon are green to red color consistent