Bug 1902 – "Nyquist Prompt" confusingly shown only as "Nyquist" when "Grouped by Type" is active

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1902 - "Nyquist Prompt" confusingly shown only as "Nyquist" when "Grouped by Type" is active


Summary:	"Nyquist Prompt" confusingly shown only as "Nyquist" when "Grouped by Type" i...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.0
Hardware:	Per OS Other

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-07-14 07:40 UTC by Peter Sampson
Modified:	2018-08-20 11:45 UTC (History)
CC List:	4 users (show)

See Also:
Steps To Reproduce:	1) Edit > Preferences Effects tab 2) select "Grouped by Type" 3) go to the Effects Menu 4) observe two seemingly identical entries for "Nyquist" 4.1) drill down and observe that one of these is for "Nyquist Prompt" 5) go to the Tools Menu 6) similarly observe two seemingly identical entries for "Nyquist" 6.1) drill down and observe that one of these is for "Nyquist Tools Prompt" 7) Edit > Preferences Effects tab 8) revert to (default) "Sorted by Effect Name" 9) Now observe in the Effects and Tools menus that are single clearly labelled entries for "Nyquist Prompt" 10) Note the discrepancy qt 4.1 "Nyquist Prompt" and 6.1 "Nyquist Tools Prompt" - and note that the name of the ensuing dialog is "Nyquist Prompt"
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2018-07-14 07:40:12 UTC

IF the user has selected "Grouped by Type" in Effects Preferences, the in the Effects and Tools Menus the "Nyquist Prompt" entry is shown as just "Nyquist".

This is confusing to the user as in both those menus there in an additional identical "Nyquist" command - but that one invokes the Nyquist effects or tools.

Additionally we have an inconsistency as:
a) in the Effects>Nyquist Menu we get "Nyquist Prompt"
b) in the Tools>Nyquist Menu we get "Nyquist Tools Prompt"
c) the ensuing dialog is labelled "Nyquist Prompt"


I'm also failing to understand why we have the "Nyquist Prompt" in both the Tools menu and the Effects menu.


See possibly related Bug #102

Comment 1 Peter Sampson 2018-07-14 07:41:41 UTC

Elevated to P2 as I think this should be a must-fix for 2.3.0

Comment 2 James Crook 2018-07-14 13:02:22 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/848b66f4fae73d1e3236dfe1b402682a01013075

Comment 3 James Crook 2018-07-14 13:05:46 UTC

The fix to the headline issue is included in the earlier commit.
https://github.com/audacity/audacity/commit/27390203429f25c71760a08f8dfc54e3ae0b55f1

Instead of showing 'Nyquist' we now show 'Nyquist Effects Prompt' and it is clickable with no submenu.  Or in Tools menu, 'Nyquist Tools Prompt' (which unlike effects allows aud-do too).

Comment 4 Peter Sampson 2018-07-15 07:40:42 UTC

(In reply to James Crook from comment #3)
Testing on W10 with James' build audacity-2.3.0-alpha-45-848b66f4fae73d1e3236dfe1b402682a01013075

Tests ok on W10
The sets of Nyqyist Commands are nicely differentiated from the Nyquist Tools menu entries.  I testing with all options od effects layouts offered in Effects prefs.

But I'm still at a loss to understand why we have what seem to be duplicate ttols, albeit with different nomenclature in the menus.
a) In Tools we have "Nyquist Tools Prompt..."
b) in Effects menu we have "Nyquist Effects Prompt..."

The minor differences are the Tools vn can be invoked (nut not effected) without a selection - whereas the Effects version is grayed out when there is no selection

And I understand (from James) that:  "The Tools one (will) allow aud-do, whereas the Effects one won't."

So why do we really need the two ?


Further the use of "Prompt" in the nomenclature is surely a historical hangover from 2.2.0 and earlier where the command was called "Nyquist Prompt..." - the "Prompt" adds nothing in the current context.

Comment 5 Peter Sampson 2018-07-16 07:00:28 UTC

I have raised the duplicate command issue as a discussion thread on quality (prior to possibly creating a new Bugzilla entry for it if it is not quickly resolved).

As This works on W10 and is using common code among the 3 platforms I shall close this bug as RESOLVED QUICKFIXED (thanks James)