Bugzilla – Bug 1906
Issues with dynamic Play-at-Speed
Last modified: 2018-08-20 11:46:01 UTC
With Commit: https://github.com/audacity/audacity/commit/17ca54ad4bb3280a05fa68702125a005f2264822 made to fix Bug #133 we now have a dynamic Play-at-Speed via the Transcription Toolbar. This bug summarizes a few known issues: 1) Playback does not stop and pop-up the Play button at the end of playing the selection. But see also Bug #815 : Enh: Clicking Transcription Toolbar Play button pushes down Transport Play button 2) The scrub widget shows uselessly on the scrub ruler when in Play at Speed mode and the status bar proclaims 'Scrubbing'. This occurs even if the Scrub Ruler is hidden as the scrub widget then appears in the Timeline 3) At low speeds the playback is clicky, with VariSpeedPlay, even if no changes to speed are being made. If we can't fix both 1 and 2 by 2.3.0 release time, VariSpeedPlay will be made false by default.
3) crackle at low speed appears to be fixed with James' latest commit: https://github.com/audacity/audacity/commit/f5999954c4b4934802857cdbe50ddb4d54e26fcb
Issues 1,2 & 3 in Comment 0 now fixed I believe, with this commit: https://github.com/audacity/audacity/commit/f0637eeb85649a90a365d572f7f179bb17f855a6 However about half the time the selection disappears on exit from play at speed. So once that status is confirmed we'll update this bug to track what's left.
Testing on W10 with audacity-2.3.0-alpha-48-f0637eeb85649a90a365d572f7f179bb17f855a6 Issues 1,2 and 3 are fixed 1) Play button is handled properly 2) no useless scrub widget shown while Play-at-Speed is playing 3) no slow-speed clickys with Play-at-Speed A fresh issue has emerged from testing: 4) moonphase: using Play-at-Speed on a selection can sometimes cause the selection to disappear on completion of playing the selection
Further issues reveled in testing: 5) Shift+Play-at-Speed, causes the Looped play button to show - but the audio only plays once and stops 6) Ctrl+Play-at-Speed, causes the Play-cut-preview play button to show - but instead of a cut preview the selection is played. See the Manual for how these are supposed to work: https://alphamanual.audacityteam.org/man/Transcription_Toolbar And indeed does work in 2.2.2 - so this is a "regression"
Comment 4 issues 5 and 6 addressed with this commit: https://github.com/audacity/audacity/commit/1403e7fa92ffca1072e4a187e630a58c3c9af2d0 Fixed play-at-speed only for cut preview and looped play. Scrubbing doesn't currently support them.
*** STEPS UPDATED *** Issues 1,2,3,5,6 addressed. The current one known residual issue is issue 4, that the selection sometimes disappears on completion of play-at-speed.
(In reply to James Crook from comment #6) Testing on W10 with audacity-2.3.0-alpha-50-1403e7fa92ffca1072e4a187e630a58c3c9af2d0 I confirm that 5 and 6 are fixed a) I get looped Play-at-Speed b) I get Play cur Preview-at-Speed Removed those from the Release Note text Removed the regression flag
For issue 4 (selection vanishing) I am finding: - It happens on Windows, and not Linux. - If I use 'Stop' rather than waiting for the playback to complete, the selection is removed every time. These two points might help us in tracking it down.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/f13e621bc15be198ecb7d3655443610c6f10dda1
(In reply to James Crook from comment #9) Testing on W10 with audacity-2.3.0-alpha-58-f13e621bc15be198ecb7d3655443610c6f10dda1 Try as hard as I might I can no longer make it lose the selection a) many, many repetitions of playing a selection played-at-speed b)many many attempts stopping a selection that is being played-at-speed
Does not need testing on other platforms. In light of comment 12, and my own testing, RESOLVED QUICKFIXED.
