Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1925 - Applying <macroname> to current project window: visual noise, and accessibility.
Applying <macroname> to current project window: visual noise, and accessibility.
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.3.0
Per OS Windows (all)
: P4 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-10 06:52 UTC by David Bailes
Modified: 2018-08-20 11:46 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
1. Run a short macro. The Apply dialog briefly appears. 2.Run a macro containing a number of short commands. The Apply... dialog appears and flashes.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
drbailes: Accessibility+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Bailes 2018-08-10 06:52:22 UTC
If you apply a macro to the current project, then an Apply <macroname> to current project window appears, even if only for a short time.

Visual problems:
If it's a short macro, the the window fleetingly appears, and has no purpose - it's just a distraction.
If it's a macro containing a number of short commands, the the window appears and flashes. Again it's a distraction, and doesn't look good at all.

Screen reader problems:
When this window closes, focus returns to the tracks causing screen readers to unnecessarily read the name of the focused track. This is noise, and could be especially unwanted if the macro includes playing some of the track.

On the quality mailing list, James suggested that this window could behave like the progess dialog - it only appears after a brief pause. However, for this to be of benifit to screen readers, the implementation would have to be different than the implementation for effects. In the latter case, the destructor of the progress dialog is run regardless of whether the progress dialog is shown, and when this happens, it causes wxWidgets to create a focus event.

Do we need to have this window at all?

I have left the priority at default, so that QA can decide.
Comment 2 David Bailes 2018-08-10 08:14:06 UTC
(In reply to James Crook from comment #1)
> DEVEL - FIX MADE
> https://github.com/audacity/audacity/commit/
> 9d396e3315e210b14f2c26e1a7a18c0189f992de

Confirmed fixed. Thanks - it looks and sounds better.