Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1938 - Global variable 'S' (sixteenth note) incorrectly set in 'tool' type effects to NIL
Global variable 'S' (sixteenth note) incorrectly set in 'tool' type effects t...
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: Nyquist
2.3.0
Per OS All
: P4 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-13 11:42 UTC by Steve Daulton
Modified: 2018-11-08 04:45 UTC (History)
2 users (show)

See Also:
Steps To Reproduce:
In Nyquist prompt, enter: ;type tool (print s) Should print 0.25000
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-11-07 00:00:00
petersampsonaudacity: Test‑OK‑Win+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Daulton 2018-08-13 11:42:55 UTC
Nyquist defines a global variable 's' as "sixteenth, 1/4 beat" (Adagio notation).
http://www.cs.cmu.edu/~rbd/doc/nyquist/part12.html#index972

In old plug-in syntax (pre-version 4), this was overridden by process type and analyze type effects as the global variable that passes the selected audio to Nyquist. For generate type effects, 'S' retained its Nyquist defined meaning.

In modern (version 4) syntax, the variable for passing the selected sound is *TRACK*, and the variable 'S' has been restored as it's original Nyquist defined meaning for all plug-in types.

As 'tool' type effects do not pass the selected audio to Nyquist, then 'S' should have it's Nyquist defined meaning for both legacy and modern syntax (as is the case for generate type plug-ins). 

As demonstrated by the steps to reproduce, if the plug-in type is 'tool', then 'S' is bound to the value NIL instead of 0.25.
Comment 1 Steve Daulton 2018-08-13 11:51:51 UTC
Fixed at:
https://github.com/audacity/audacity/commit/8eef6dc
Comment 2 Peter Sampson 2018-11-07 08:36:05 UTC
Testing on W10 with audacity-2.3.1-alpha-207-4c76e598d5859dc172e063d37287cc510fa7850f

This now tests OK on Windows

As this is marked RepeatableHome I shall close this as RESOLVED
Comment 3 Peter Sampson 2018-11-07 08:36:47 UTC
RepeatableAll that is (I hate auto correction)