Bugzilla – Bug 2028
Mac: Audacity crashes when right clicking in label after copying label text to ano app
Last modified: 2018-12-03 07:20:32 UTC
Originally reported on the Froum by user jarome jarome wrote: ↑ Wed Nov 07, 2018 3:55 pm And I reported another bug a long time ago, and it has not been fixed. If you hit command B to add a label, and then go to a different program to say, copy the label contents. If you then return to Audacity by right-clicking the label box, Audacity crashes every time. I confirm that I can repeat this on 2.3.0 and earlier versions of Audacity back to 2.1.3 (the oldest Audacity I have on my Mac)
Testing on W10 with audacity-2.3.1-alpha-167-86fb0368e50b36ecf7eba2a96e2d581959695f62 this works fine with no crash And testing on the 64-bit 2.3.1 Mac build it crashes just like 2.3.0 32-bit Mac build does. And this occurs in all Mac Audacities back to 2.1.2 (the oldest Audacity I have on my Macbook Pro)
Build 64bit commit 800dda and the steps to reproduce do not cause a crash. Tried multiple times with different labels and text length. Appears to be fixed.
Could it be a Mojave issue? Ok on Sierra.
Ok also on High Sierra.
Testing on Cliff's original 64-bit build and his latest 29Nov18 800dda build. This still fails with a crash on Mojave 10.14.1
Peter: Does it still happen if you do something else in Audacity before the right click (step 7)?
(In reply to Cliff Scott from comment #6) >Peter: Does it still happen if you do something else in Audacity before the right click (step 7)? No it doesn't. If I left click in the waveform, or left click in the label and then right click in the label the crash does not happen and the context menu appears.
That's what I expected. One more test if you don't mind, Peter. Substitute TextEdit for Notes and run the test.
(In reply to Cliff Scott from comment #8) >One more test if you don't mind, Peter. >Substitute TextEdit for Notes and run the test. Yes it still crashes when I do this.
Ok. That eliminates one possible cause. I'm trying to nail down exactly what operation is causing the issue. What happens if you just skip step 5, i.e. don't actually paste, but do everything else except that? What happens if you just switch to another app after the copy in Audacity, then back to Audacity and right click on the label? What happens when you return to Audacity and if you just click on the label first to clear the highlighting then right click on the label?
(In reply to Cliff Scott from comment #10) >What happens if you just skip step 5, i.e. don't actually paste, >but do everything else except that? > >What happens if you just switch to another app after the copy in >Audacity, then back to Audacity and right click on the label? 1) get some audio 2) create a label and add label text 3) select and copy the label text 4) open Notes 5) omit step 5 6) minimize the Notes window 7) in Audacity window right click on the label 8) => Audacity crashes 1) get some audio 2) create a label and add label text 3) select and copy the label text 4) omit step 4 5) omit step 5 6) omit step 6 7) in Audacity window right click on the label 8) => context menu opens property, no crash >What happens when you return to Audacity and if you just click >on the label first to clear the highlighting then right click >on the label? I documented that in Comment #7- but here we go 1) get some audio 2) create a label and add label text 3) select and copy the label text 4) open Notes 5) paste the label contents into Notes 6) minimize the Notes window 7.1) in Audacity window left click on the label 7.2) in Audacity window right click on the label 8) => context menu opens property, no crash
Thanks Peter. In the second case did you actually switch to another app, i.e. bring it to focus, then back to Audacity? You didn't do step 4 so I don't think the focus changed from Audacity. I expect if you did step 4 then Audacity would have crashed. It appears as if going back to Audacity and using the right click to restore focus as well as open the context menu doesn't work well in Mojave. For some reason that works fine in the older MacOS versions. How to work around that should be an interesting challenge for the developers.
(In reply to Cliff Scott from comment #12) >In the second case did you actually switch to another app, >i.e. bring it to focus, then back to Audacity? >You didn't do step 4 so I don't think the focus changed from Audacity. >I expect if you did step 4 then Audacity would have crashed. 1) get some audio 2) create a label and add label text 3) select and copy the label text 4) open Notes 5) click cursor in Notes 6) minimize the Notes window 7) in Audacity window right click on the label 8) => Audacity crashes
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/5e1ec8dbe5acf8d0ded0857444ad6913519b7f1f Although I now see no crash, the context menu does not appear when we follow the steps to reproduce. If we decide to track that, it's a new low priority (OSX only) bug.
(In reply to James Crook from comment #14) Tested on macOS Mojave 10.14.1 with Cliff's 253aca7 build As James reports I no longer get the crash, but the context menu does not appear on the right click. And from Cliff's reports this would seem to only affect Mojaqve So this P1 bug can be closed as RESOLVED - but I will raise a P4 bug for the non-appearance of the context menu.
Residual logged as Bug #2044
