Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2031 - Equalization: presets under the Manage button do not save custom EQ curves
Equalization: presets under the Manage button do not save custom EQ curves
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Built-in FX
2.1.2
Per OS All
: P1 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-11-17 05:09 UTC by Steve Daulton
Modified: 2019-08-22 05:29 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
1) Save a preset with an "unnamed" curve. 2) Change the curve 3) Restore the curve saved in step 1 Note that GUI settings are restored, but the unnamed curve is not restored.
Release Note:
Group: Effects When using the Manage button in the Equalization effect, the Presets features are not working yet.
First Git SHA:
Group: ---
Workaround:
Use Save / Manage Curves to save, rename, export and import predefined curves.
Closed: 2019-08-22 00:00:00
james.k.crook: Must‑Test‑All‑OS-
james.k.crook: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Win+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Daulton 2018-11-17 05:09:05 UTC
Presets under the Manage button save / restore the GUI button and slider settings, but not the all important Eq settings.

The Eq setting must first be saved as a named preset before they can be used in a "Manage button" preset.

I've only tested on Linux, but I expect this is "all platforms".

The issue goes back to at least 2.1.2, but I suspect (but I'm not certain) that this has never worked, in which case this should be logged as "Enh".
Comment 1 Peter Sampson 2018-11-17 06:49:09 UTC
Indeed this has never worked.

Gale wrote in an ednote and a visible user-warning  in the manual back in 2016
https://alphamanual.audacityteam.org/man/Equalization#buttons

>Other buttons
>
>Clicking on the command buttons give the following results:
>Gale 31May16: I added that presets do not work yet and put the link 
>to Manage presets in an ednote.
>
>    Manage gives a dropdown menu enabling you to click "About" to see some >details about the effect. 
>
>Warning icon 	The Presets features are not working yet. Use Save / Manage Curves >to save, rename, export and import predefined curves.


Until now this has never been logged as a bug or an enhancement.  But users who do not bother to read the Manual (and we know there are many of those) will not see the warning and they will assume from the GUI that it should work.

------------------------------------------------------

Actually this is a mess of our own making from when we added the Manage button to this effect - thereby creating a secondary way of managing curves - when we already had the longstanding "Save/Manage Curves" button and the "Select Curve" dropdown menu.

To have two different ways of doing the same thing is more than confusing.

And worse still curves managed with one tool do not migrate to become available with the other tool.
Comment 2 Peter Sampson 2018-11-17 06:53:05 UTC
I raised this to P3 (but I think it is marginal P2) and added a Release Note and Workaround
Comment 3 Peter Sampson 2018-11-17 07:49:05 UTC
The simplest way to resolve this issue would be to just remove the "Manage" button from this effect.  And I would fully support doing this.

I raised a discussion thread on the quality list proposing this.
Comment 4 Peter Sampson 2018-11-17 10:13:10 UTC
Raising the Priority to P2 - to make this a possible fix for 2.3.1
Comment 5 Peter Sampson 2019-08-07 07:42:44 UTC
Promoting to P1 to raise focus level re. EQ changes for 2.3.3
Comment 6 James Crook 2019-08-21 13:19:26 UTC
DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/23063511d9c41d32963c7722e353ea458af9065f

Effect has been split into two, and equalization has not yet been removed.  Suggest discussing residuals on quality@ list rather than filling this bug up with residuals.  There are probably many feature requests which follow from fixing this bug.  There may also be residuals such as in behaviour from scripting.

If the 'headline' bug here "Equalization: presets under the Manage button do not save custom EQ curves" has been fixed, this bug should be closed.
Comment 7 Peter Sampson 2019-08-22 05:06:54 UTC
Testing On W10 with audacity-2.3.3-alpha-326-c9fbd283b7bfc8702caf86a4672cba7ff6260b7d

This now tests OK on Windows (as do its two new close cousins - the split effects)