Bug 2038 – Metadata editor opens without grid focus

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2038 - Metadata editor opens without grid focus


Summary:	Metadata editor opens without grid focus

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.1
Hardware:	Per OS Linux

Importance:	P4 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-11-26 13:24 UTC by Steve Daulton
Modified:	2019-04-13 15:09 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1) "Edit menu > Metadata" 2) Right cursor to the the first editable cell ("Artist Name" value). Focus does not move to first editable cell
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-04-13 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS- petersampsonaudacity: Test‑OK‑Win+ james.k.crook: Test‑OK‑Win+ james.k.crook: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2018-11-26 13:24:37 UTC

Tested on Linux. Suspect also Mac but not tested.

On opening the Metadata tags editor, cursor keys move focus to buttons, not to grid cells.

This can be fixed by adding:
mGrid->SetFocus();
to TagsEditor::TagsEditor()
before:
PopulateGenres();

Comment 1 James Crook 2019-04-12 15:19:42 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/f66e753c540fc41702263387bf69d29e01283815

Comment 2 Peter Sampson 2019-04-13 12:31:17 UTC

(In reply to James Crook from comment #1)
Testing on W10 with audacity-2.3.2-alpha-234-5c361631c6aa9868d8e985d18f103fa69887fdcb-1

The dialog opens with focus on the "Artist Name" - and the arrow keys navigate between the cell fields and not the buttons.

Comment 3 Steve Daulton 2019-04-13 13:16:38 UTC

As in the bug description, this fix works for me. I think this bug can be solved as fixed, but as it's my fix, someone else should do that.