Bugzilla – Bug 2049
ENH: Noise Reduction error message for no selection is unhelpful
Last modified: 2019-08-09 05:25:36 UTC
What is particularly bad is the general error message you get with this effect (the standard generalized error message for all effects): >You must first select some audio to perform this action >(Selecting other kinds of track won't work) Now this message is fine and dandy for all the other effects - but for NR it would be much better if we had a special error message just for that effect, having similar text to the info text in the effect dialog (explaining briefly the two pass process). Note that currently the user has to make a selection and enter the NR effect to see that instructions in the dialog. The current generic message may also encourage the user to select the whole audio for NR, not realizing that they need a small noise profile first - and the unwise (or those that don't read) may just use the whole selection as their noise sample See also Bug #2048 "Slicker Noise Reduction GUI"
I think it would be better to make this (from a user perspective) a "one pass effect", rather than giving it a custom error message. (See also bug 2048#c3)
(In reply to Steve Daulton from comment #1) I agree Steve - but in the meantime until (if ever) we make it a one-pass effect this small change will be a much more "friendly educational message"
(In reply to Peter Sampson from comment #2) I don't think that's a very good use of developer time. The Noise Reduction effect is the last "old style" effect, and there's a ton of old code cluttering Effect.cpp / Effect.h that is there only because it is required by this one effect. The Noise Reduction effect really does need updating, then there can be a substantial clean-up of Effect.cpp.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/0bd1beae9a92c9753b04c160c0dd649ddd13939d
(In reply to James Crook from comment #4) Testing on W10 with audacity-2.3.3-alpha-307-0bd1beae9a92c9753b04c160c0dd649ddd13939d Looks good on Windows - a much improved and much more helpful error message
Testing on macOS 10.14.5 Mojave with 2.3.3 Mac alpha jc005 of 01Aug19 On Mac when no selection is made the Noise Reduction effect (as are all non-RTP effects) is grayed out - so no message at all can be seen. This behavior is different to Windows - is this what we want on Mac ?
Note that this cannot be tested until Bug #2184 is properly fixed
(In reply to James Crook from comment #4) Testing on mac)S 10.14.6 29th 2.3.3. alpha jc006 of 08Aug19 Now looks good on Windows too - a much improved and much more helpful error message
