Bugzilla – Bug 2064
Linux: ESC key does not work to abort drags in the Timeline Ruler
Last modified: 2019-04-05 08:50:44 UTC
ESC key won't work to abort drags in the time Ruler on Linux. That includes play region boundaries and the pinned play head. This is a residual as a result of the fix (on Linux) for Bug #2056
Reduced to P4 following discussion with Steve
I misunderstood what this bug was until I tried it, but now that I've tried and tested it, what's wrong with just pressing Spacebar to stop Quick Play, or am I missing something? With regard to dragging a pinned play head, why do I need to be able to escape from a drag (requiring use of my other hand) when I can simply drag it back with the mouse, that is already dragging the play head?
I have already worked out a fix for this in a branch in my fork: https://github.com/audacity/audacity/commit/07e50b60eebcc174cf464c67baa487d49deb934f I also updated steps to reproduce to include drags of the pin.
(In reply to Steve Daulton from comment #2) I wish to have a uniform convention in the user interface, that any mouse drag can be escaped with the key. If a user knows this convention, which other applications follow too, then it relieves them of the annoyances of unintended drags of the wrong thing and makes it easy to restore things to their exact state before the drag. I did much work to make this so for TrackPanel and for dragging of toolbars. I want it so for the drags in the time ruler too.
Not yet "Fix made" while this commit is not in master.
(In reply to Paul L from comment #4) > If a user knows this convention, which other applications follow too... "Some" other applications follow this convention, but it far from universal. For example, in Firefox, if I scroll the window using the vertical scroll bar, the Esc key does nothing. While conventions are useful for maintaining consistent behaviour, we don't have to be obsessive about them in cases where they offer little or no added value.
(In reply to Steve Daulton from comment #6) That sounds like an argument to treat the fix as low priority, as indeed it was assigned, but not an argument against attempting it at all. There was also my desire to unify commonalities in mouse event handling of TrackPanel and AdornedRulerPanel in one common base class -- which make that big complicated AdornedRulerPanel::OnMouseEvents function go way in favor of classes derived from UIHandle. Having done that, ESC key handling becomes an easy extra part of the bargain.
(In reply to Paul L from comment #7) Yes, I think it's a low priority bug, but it is a bug non the less, as it is not the behaviour that you intended.
fixed at https://github.com/audacity/audacity/commit/02db402b5491e3f321ec0412a7e8df4133bc9ab7
Works for me. Resolved Fixed.
