Bug 2069 – Macros: Change Pitch in a Macro does not remember speed parameter setting

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2069 - Macros: Change Pitch in a Macro does not remember speed parameter setting


Summary:	Macros: Change Pitch in a Macro does not remember speed parameter setting

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.3.1
Hardware:	Per OS All

Importance:	P1 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:	https://forum.audacityteam.org/viewto...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-02-15 10:51 UTC by Peter Sampson
Modified:	2019-02-19 08:42 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1) Create a Macro with Change Pitch 2) Set a non-zero value for the percentage pitch change 3) Exit Audacity 4) Relaunch Audacity 5) Open your Macro 6) observe that the pitch-change percentage parameter has been reset to default null 0%
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:

Flags:	james.k.crook: Must‑Test‑All‑OS- petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ james.k.crook: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2019-02-15 10:51:07 UTC

When using Change Pitch in a Macro the user's preferred percentage pitch-change is not remembered between Audacity sessions.  This appears to the user that their Macro fails to work (as it runs but produces a null change).

Note that the flag parameter setting for "Use high quality stretching" is properly remembered.

This is a regression on 2.2.0

This also happens to chains created in 2.2.2 that get transferred to 2.3.0


Note that Change Speed and Change Tempo are not similarly affected - they retain their setting between Audacity sessions.

Comment 1 Peter Sampson 2019-02-15 10:54:18 UTC

See this Forum bug thread for original bug report:  https://forum.audacityteam.org/viewtopic.php?f=50&t=103706

Comment 2 Peter Sampson 2019-02-15 11:01:28 UTC

Note that this also similarly affect the Change Pitch effect when run directly - it fails to remember its settings used in the previous Audacity session - Change Speed and Change Tempo do remember their settings between Audacity sessions.

This is also a regression on 2.2.0

Comment 3 Steve Daulton 2019-02-17 14:12:15 UTC

(In reply to Peter Sampson from comment #2)
Fix committed at 
https://github.com/audacity/audacity/commit/e609a9d

Comment 4 Peter Sampson 2019-02-18 05:02:28 UTC

(In reply to Steve Daulton from comment #3)
Testing on W10 with Steve's AppVeyor build https://manual.audacityteam.org/man/tutorial_copying_tapes_lps_or_minidiscs_to_cd.html

This now works correctly.

1) The setting made in a Macro for Change Pitch is properly retained and not reset

2) It now works re Comment #2 - Audacity correctly "remembers" that last-used setting for Change pitch after a restart of Audacity.

Comment 5 Cliff Scott 2019-02-18 21:49:26 UTC

Tested with Steve's new fix on MacOS 10.13.6 and all tests good. Values are remembered separately for Audacity general and in Macros.

Comment 6 Peter Sampson 2019-02-19 05:52:19 UTC

(In reply to Cliff Scott from comment #5)
Testing with the latest Mac 64-bit build provided by Cliff on 18Feb19 I confirm Cliff's findings that this now also runs properly on Mac (macOS 10.14.3 in my case)

Comment 7 Peter Sampson 2019-02-19 08:42:15 UTC

I asked James to test this on Linux - he replied

>Tested, and it is fine now.