Bug 2072 – Linux: Min-source build failure if libid3tag not installed on system

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2072 - Linux: Min-source build failure if libid3tag not installed on system


Summary:	Linux: Min-source build failure if libid3tag not installed on system

Status:	RESOLVED WORKSFORME

Product:	Audacity
Classification:	Unclassified
Component:	Installer
Version:	2.3.1
Hardware:	Per OS Linux

Importance:	P2 Repeatable
Assigned To:	Steve Daulton

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-02-26 14:59 UTC by Steve Daulton
Modified:	2019-05-12 07:28 UTC (History)
CC List:	4 users (show)

See Also:
Steps To Reproduce:	Follow these instructions to install the Audacity min-source tarball on a fresh installation of Ubuntu Bionic: https://wiki.audacityteam.org/wiki/Building_On_Linux#Instructions_.28Used_by_James_on_bionic.29 The build fails as described in comment 1.
Release Note:	Linux: Before compiling Audacity from the minsrc tarball, it is essential to either install libid3tag ("libid3tag0-dev" on Debian / Ubuntu based distros), or copy the libid3tag folder from GitHub into the lib-src folder.
First Git SHA:	e860502
Group:	---
Workaround:
Closed:	2019-05-11 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS- stevethefiddle: Regression+ james.k.crook: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2019-02-26 14:59:26 UTC

If libid3tag is not installed on the system, "make" fails with error:
export/ExportMP3.cpp:1622:4: error: ‘id3_length_t’ does not name a type; did you mean ‘int_least8_t’?

This is a regression against Audacity 2.2.2 tarball.

The problem is caused by:
https://github.com/audacity/audacity/commit/e860502
(fixed types in ExportMP3.cpp to avoid "signed vs. unsigned" warnings )

To fix this bug:

In ExportMP3.cpp, replace each occurrence of:
id3_length_t
with
unsigned long

Comment 1 Steve Daulton 2019-03-10 13:36:57 UTC

Fix committed at https://github.com/audacity/audacity/commit/8012f6b

Comment 2 James Crook 2019-05-11 08:30:43 UTC

I did not follow the exact steps, as I did not want to re-install Ubuntu, but certainly compiles fine with the changes in comment 1.  So marking it as RESOLVED WORKSFORME on a technicality.  RESOLVED FIXED is what we actually believe.

Comment 3 Steve Daulton 2019-05-12 07:28:45 UTC

(In reply to James Crook from comment #2)
James wrote:
> I did not want to re-install Ubuntu

Just for information, the bug could be reproduced by uninstalling libid3tag (for example, use Synaptic package manager to remove libid3tag0 and libid3tag0-dev), then downloading the Audacity source prior to the fix, and attempt building.