Bug 2077 – Mac - FFmpeg Custom options dialog opens behind Export Audio dialog

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2077 - Mac - FFmpeg Custom options dialog opens behind Export Audio dialog


Summary:	Mac - FFmpeg Custom options dialog opens behind Export Audio dialog

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.1
Hardware:	Mac macOS

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-03-11 11:20 UTC by Bill Wharrie
Modified:	2019-09-01 13:44 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1) On Mac (any OS), Audacity 2.2.2 through 2.3.3 alpha 2) File > Export > Export Audio 3) File Type: Custom FFpeg Export 4) Click “Open custom FFpeg format options" 5) Observe: the custom options dilog is popped up - but hiddn behind the export dialog - many users will fail to find it - plus the "Cancel" in the Export dialog is blocked by the invisible custom options dialog
Release Note:	Group Exports *On macOS the FFmpeg options dialog opens behind Export Audio dialog and cannot be brought to the front.
First Git SHA:
Group:	---
Workaround:	Move the windows around to see the options.
Closed:	2019-09-01 00:00:00

Flags:	petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ flyer185: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Bill Wharrie 2019-03-11 11:20:03 UTC

The export options window opens behind the Export Audio dialog and cannot be brought to the front. You have to move the windows around to see the options.

Comment 1 Peter Sampson 2019-03-11 13:43:05 UTC

Regression on 2.2.2

Comment 2 Peter Sampson 2019-03-13 07:02:00 UTC

Upgrading this to P2 as for me (with QA hat on) this is a "really-should-fix" for 2.3.2

Comment 3 Peter Sampson 2019-06-12 07:46:49 UTC

This is still the case on 2.3.3 alpha jc001

Comment 4 Peter Sampson 2019-08-02 10:23:49 UTC

And still the case on JC005

I am upgrading this to P1 as it has kept tripping (even) me up while testing Custom FFmpeg export on Mac

The custom options dialog is popped up - but hiddn behind the export dialog - many users will fail to find it (I struggle to remember what's occurring)  - plus the "Cancel" in the Export dialog is blocked by the invisible custom options dialog.   This makes the functionality barely usable and certainly user-unfriendly.

Comment 5 Paul L 2019-08-28 12:00:44 UTC

Fixed at

https://github.com/audacity/audacity/commit/7149d8fcf9ccd79c4121f9319299bec7d3c8292c'

Comment 6 Cliff Scott 2019-08-28 15:16:40 UTC

MacOS 10.14.6, Commit: 7149d8

Dialogs are properly displayed with the Custom Options Ffmpeg window in the foreground and the Export behind. Canceling the Options window leaves the Export window in the foreground as it should.

Comment 7 Peter Sampson 2019-08-28 15:30:19 UTC

Closing this on the basis of Cliff's successful test

Comment 8 Peter Sampson 2019-08-29 06:29:45 UTC

And tests OK on macOS 10.14.6 Mojave with 2.3.3 alpha jc008 of 29Aug19

Comment 9 James Crook 2019-08-30 14:03:29 UTC

FIXED RESIDUAL.
https://github.com/audacity/audacity/commit/fe3a86611793f7f199133561a954f15caf9a390d

The fix at comment 5 was wrong for windows, as it caused an ASSERT, so that is now fixed by only using the new code on OSX.

Comment 10 Peter Sampson 2019-09-01 13:44:56 UTC

(In reply to James Crook from comment #9)
Testing on W10 with audacity-2.3.3-alpha-341-72f36f8a82e9ed4a184b9029cb53780e62a9bea8

I cpnfirm this now works properly again without the assert/wxwidgets debug failur message