Bugzilla – Bug 2093
Note Track: Vertical Zoom Reset produces max. zoom out and not a reset
Last modified: 2019-04-16 06:12:04 UTC
Using the Reset in the right-click context menu of the Vertical Scale in a Note Track produces the same result as using Shift+Right-click in the Advanced Vertical Zooming mode - it produces a maximum zoom out to show the entire range of notes (from C -1 to G 9). This a max zoom and not a Reset. Reset should restore the same zoom level as that which obtained when the user first imported the MIDI track (this is what happens with audio tracks in waveform and spectrogram modes. Correct behavior at Step 3) in the Steps to reproduce should be absolutely no change of display - i.e. no zooming at all. And after any subsequent VZooms in/out a Reset shoul restore to the VZoom level at step1). The Manual does actually descibe accurately the behavior that currently obtains with the VZoom Reset - but this is incorrect behavior - inconssistebt with the similar Reset for audio tracks. https://alphamanual.audacityteam.org/man/Vertical_Zooming#note This is not a regression - it is the same on earlier Audacity versions.
Created attachment 819 [details] Note Track after a Vertical Zoom Reset Note Track after a Vertical Zoom Reset - note that this is not a Reset to "normal" zoom level.
I think that I also included a change relevant to this in https://github.com/audacity/audacity/pull/232 -- but it was a while back. My implementation did change the default zoom (to fix bug 1815). It looks like (https://github.com/audacity/audacity/pull/232/commits/d6276f5279c2197db5979277a19a02627c594956) I also added a separate "max zoom" menu item that behaves the same as the current behavior, while zoom reset does do the default zoom (which was changed to show the top and bottom notes). I also made it so that shift+right-click returned to the default zoom, unless it already was the default in which case it did the max zoom. I'll try to create an updated version of that pull request, since it's been a while and I don't quite know how everything behaved.
Updated pull request: https://github.com/audacity/audacity/pull/352
DEVEL - FIX MADE by Pokechu22 https://github.com/audacity/audacity/commit/1866be61453b6b2564deb961394c81e357f2baf9
(In reply to James Crook from comment #4) Testing on W10 with audacity-2.3.2-alpha-236-1866be61453b6b2564deb961394c81e357f2baf9 This now works as a proper Reset, restoring the vertical zoom level to that which obtained when the MIDI file was imported. Tested with Multiple Midi tracks - each one resets to its own proper reset Vzoom level.
