Bug 2109 – Incorrect mute button behaviour when importing into project with soloed track

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2109 - Incorrect mute button behaviour when importing into project with soloed track


Summary:	Incorrect mute button behaviour when importing into project with soloed track

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	2.3.2
Hardware:	Per OS All

Importance:	P3 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-05-05 07:22 UTC by Steve Daulton
Modified:	2020-12-02 08:14 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1) Launch Audacity 2) Generate a chirp 3) Duplicate the track 4) Solo the first track 5) Import an audio file 6) Observe: the imported file creates a track that is muted, but the mute button is not down.
Release Note:	GROUP: Import/Export *Importing audio into a project with a soloed track can lead to incorrect state for mute/solo buttons.
First Git SHA:
Group:	Import
Workaround:	After importing a track, if the mute/solo buttons are showing incorrectly, click on the mute/solo buttons to get the mute soloing you want, and showing correctly.
Closed:	2020-12-02 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2019-05-05 07:22:16 UTC

If a track is soloed, then importing a file creates a track that is muted, but the mute button is not down.

The expected behaviour could be either:
* The imported track will be muted and its mute button will be down
* The imported track will not be muted and its mute button will not be down
* The imported track will not be muted and its solo button will be down

I think either of the first two options are preferred. The current behaviour is clearly wrong.

This bug is also present in versions back to Audacity 2.2.0. I've not tested earlier than that.

Bug confirmed on Windows and Linux, so assumed "All".

Comment 1 Peter Sampson 2019-05-05 10:14:04 UTC

This bug looks suspiciously like Bug #1799 Use Case B - which I closed off yesterday as I could not then reproduce it - but testing today on Mac and W10 with 2.3.2 RC001  I can reproduce 1799 and this bug's steps.

Comment 2 Peter Sampson 2020-09-10 04:55:52 UTC

Testing on W10 with Audacious 3.0.0 6e4f163

This now works properly on Windows.

Comment 3 Peter Sampson 2020-09-10 05:06:43 UTC

Testing on macOS 10.15.6 Catalina with Audacious 3.0.0 6e4f163

This now works properly on Mac as well a Windows.

As this bug is not marked "+" fur Must-Test-All-OS I shall mark this as RESOLVED

Comment 4 Paul L 2020-11-21 16:03:15 UTC

The fix was incomplete.  The problem could happen also with import of MIDI.

Comment 5 Paul L 2020-11-21 16:04:11 UTC

791dbea1af4192708592970ea2652e6ebd0205cd completes the fix.

Please test again both with wave and MIDI track imports.

Comment 6 Peter Sampson 2020-11-22 11:54:35 UTC

(In reply to Paul L from comment #5)
Re-tested on W10 with Audacity 3.0.0 98d8603

with both WAV files and MIDI files imported at step 5
a) the imported track is grayed out (muted)
b) AND the Mute button is down

Comment 7 Peter Sampson 2020-11-22 11:58:37 UTC

Re-tested on W10 with Audacity 3.0.0 98d8603

with both WAV files and MIDI files imported at step 5
a) for WAV (and MP3)  and MIDI the imported track is grayed out (muted)
b) AND the Mute button is down

Comment 8 Paul L 2020-11-22 16:07:24 UTC

(In reply to Peter Sampson from comment #7)
Why is it reopened then?  What is the residual problem?

Comment 9 Peter Sampson 2020-11-22 17:47:17 UTC

(In reply to Paul L from comment #8)
OOPS sorry that was a mistake.

When I first tested on Mac it looked like the MIDI import wasn't being muted so I marked it REOPENED - and then retested a few times to be sure and found it was indeed working.

We're now just waiting for a Linux test on this.

Comment 10 Steve Daulton 2020-12-02 08:14:07 UTC

Works for me on Linux.