Bug 2112 – Crash when opening Equalization settings in a Macro

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2112 - Crash when opening Equalization settings in a Macro


Summary:	Crash when opening Equalization settings in a Macro

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.3.2
Hardware:	Per OS All

Importance:	P1 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:	https://forum.audacityteam.org/viewto...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-05-19 19:20 UTC by Steve Daulton
Modified:	2020-03-06 14:16 UTC (History)
CC List:	6 users (show)

See Also:	2321
Steps To Reproduce:	1) Tools > Macros 2) Insert "Equalization" into any Macro (or a new Macro) 3) Select the "Equalization" effect 4) click the "Edit" button. 5) Observe: Audacity crashes with a debug report.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-08-06 00:00:00

Flags:	stevethefiddle: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2019-05-19 19:20:13 UTC

Probably related to bug 1722.

Regression against Audacity 2.1.2

Alternative steps to reproduce, as described on the forum:
https://forum.audacityteam.org/viewtopic.php?p=370238#p370238

1. Tools -> Macros
2. New -> 'Test Macro'
3. Insert -> Equalization -> Edit parameters

Comment 1 Peter Sampson 2019-05-20 04:31:07 UTC

Surely as a predictable, readily reproducible, crash and as a regression this should really be P1

Comment 2 Steve Daulton 2019-05-20 07:00:13 UTC

(In reply to Peter Sampson from comment #1)

I think it's quite likely that this is the same bug, but with more repeatable steps as bug 1722, which is P3.

Our practice has not been to automatically rate repeatable crash issues as P1. If we did, bug 276 would have been a P1 issue for the last 8 years.

We don't usually rate crashes caused by effects as P1, though I agree we are more likely to for built-in effects than for 3rd party plug-ins.

My point is that while this is clearly a serious bug, I don't think it is "automatically" a P1.

In this case, the steps describe a fairly "advanced" operation (creating a macro), with very specific options (making a macro AND using Equalization in the macro AND editing the Equalization effect properties in the macro).

In my testing, this bug has NOT caused any loss of work, and there is an effective workaround (see: https://forum.audacityteam.org/viewtopic.php?p=370247&#p370247)

All considered, yes it's an important bug, but not "the most important" (as implied by a "P1" rating). If I were release manager, I'd probably block on this bug, but as not the release manager, I'd leave that to the RM's discretion.

If you disagree with my reasoning, let's discuss on the QA list and post just the upshot here.

Comment 3 Peter Sampson 2019-07-09 16:29:31 UTC

Upgrading to P1 following discussion with Steve on Quality email list

Comment 4 Paul L 2019-07-14 11:27:19 UTC

Fixed at https://github.com/audacity/audacity/commit/5797637528b02d4b6f2218fe923abf8b8e855782

Comment 5 Peter Sampson 2019-07-15 09:29:03 UTC

(In reply to Paul L from comment #4)
Testing on W10 with audacity-2.3.3-alpha-286-582d8afdcb54aa921d29310368d854ec308e65ae

At Step 4) the effect opens for parameter setting - there is no crash.

Looks to be fixed on Windows

Comment 6 Peter Sampson 2019-07-25 07:27:19 UTC

(In reply to Paul L from comment #4)
Testing on macOS 10,14.5 with mac 2.3.3 alpha jc004 of 25Jul19

At Step 4) the effect opens for parameter setting - there is no crash.

Looks to be fixed on Mac as well

Comment 7 Steve Daulton 2019-08-06 15:25:43 UTC

Works for me. Closing as fixed.