Bug 2113 – Label editor: After it closes, no control is the focus

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2113 - Label editor: After it closes, no control is the focus


Summary:	Label editor: After it closes, no control is the focus

Status:	CLOSED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.2
Hardware:	Per OS All

Importance:	P3 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-05-22 06:41 UTC by David Bailes
Modified:	2019-08-10 11:35 UTC (History)
CC List:	5 users (show)

See Also:	2196
Steps To Reproduce:	1) get some audio 2) Label it somewhere 3) get focus on one of the two tracks 4) Open and then close the Label editor. 5) Observe: Observe: Nothing is the focus.
Release Note:
First Git SHA:	7c0d05fc18df73789f8af0c89d75ff6fe5fadec5
Group:	Accessibility
Workaround:
Closed:	2019-08-10 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Lin?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Bailes 2019-05-22 06:41:42 UTC

This bug has been present in 2.3.1 and 2.3.2.

For keyboard users, a work around is to alt+tab away from the Audacity window and then alt + tab back.

This bug appears on Windows - Mac and Linux not tested.

Comment 1 David Bailes 2019-05-22 06:53:29 UTC

Fixed at:
https://github.com/audacity/audacity/commit/14601660d98ec41470161c2292361d34d668f6b8

This needs testing on all platforms.

Comment 2 Peter Sampson 2019-07-11 13:34:27 UTC

(In reply to David Bailes from comment #1)
Testing on W10 with audacity-2.3.3-alpha-281-dd369da6a0990c4dc323907c93246ba7135807ab

At step 5 focus remains where it was placed in step 3 - looks to be working OK on Windows

Comment 3 Peter Sampson 2019-07-12 06:09:37 UTC

(In reply to David Bailes from comment #1)
Teating on macOS 10.14.5 with 2.3.3 alpha jc003 11Jul19


As with Windows, at step 5 focus remains where it was placed in step 3 - looks to be working OK on Windows

Comment 4 Steve Daulton 2019-08-09 09:59:31 UTC

Testing on Xubuntu, after step 4, focus is on the Recording setting of the Device Toolbar.

Comment 5 David Bailes 2019-08-10 07:16:20 UTC

As a result of comment #4, the title and the steps to reproduce were changed.
The problem with doing this, is that most of the comments on this bug now refer to a different bug title, and different steps to reproduce. This is very confusing.

The no focus issue was fixed. I think that it would be much clearer to treat the focus issue on Linux as a separate bug. I suspect that it's related to bug 2115. My guess is that on Linux if the tracks are the initial focus, and any dialog is opened and then closed, the focus does not return to the tracks.

Comment 6 Peter Sampson 2019-08-10 11:28:34 UTC

(In reply to David Bailes from comment #5)
>The no focus issue was fixed. I think that it would be much clearer to treat the focus issue on Linux as a separate bug.

OK, so I restored this bug to its earlier state - and closed it as it works on Mac and Windows.  

And strictly as per the wordong of this bug it works on Linux too as focus is restored, but just not where it should be.

The residual on Linux I will log as a separate bug

Comment 7 David Bailes 2019-08-10 11:31:36 UTC

(In reply to Peter Sampson from comment #6)
> (In reply to David Bailes from comment #5)
> >The no focus issue was fixed. I think that it would be much clearer to treat the focus issue on Linux as a separate bug.
> 
> OK, so I restored this bug to its earlier state - and closed it as it works
> on Mac and Windows. 

Thanks.
 
> 
> And strictly as per the wordong of this bug it works on Linux too as focus
> is restored, but just not where it should be.
> 
> The residual on Linux I will log as a separate bug

Comment 8 Peter Sampson 2019-08-10 11:35:19 UTC

(In reply to Peter Sampson from comment #6)
>The residual on Linux I will log as a separate bug

Logged as P5 Bug #2196 - Linux: Label editor: after it closes, focus is shifted to the Device Toolbar