Bug 2119 – Linux: Incorrect behaviors in "Manage Macro"

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2119 - Linux: Incorrect behaviors in "Manage Macro"


Summary:	Linux: Incorrect behaviors in "Manage Macro"

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Other
Version:	unspecified
Hardware:	Per OS Linux

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-06-04 07:27 UTC by Steve Daulton
Modified:	2019-08-07 13:21 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1) Add a custom Macro. 2) Rename the Macro created in step 1. 3) Use the "Remove" button to remove the duplicate. 4) Observe: The Macro created in step 1 is irretrievably lost.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-08-07 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2019-06-04 07:27:19 UTC

Tested on Linux with Audacity 2.3.3 alpha.
Marked as P2 as this can cause work to be deleted and unrecoverable.

Examples

1) "Rename" creates two entries in the Macro list with the same name.
Both versions appear to be identical.

2) Remove ONE of the duplicate Macros.
Note that ALL instances of the Macro are permanently deleted.

3) When selecting either of the shipped Macros ("Fade Ends" or "MP3 Conversion"), the "Remove" and "Rename" buttons are greyed out. This implies that these Macros are "protected", but you can still modify the commands, add new commands or delete commands from them (so apparently NOT protected).

4) If a shipped Macro is modified, there is no obvious way to restore the shipped version. The modified, shipped Macro can be restored by deleting it and restarting Audacity, then Audacity will restore the shipped Macro, but shipped Macros cannot be deleted via the GUI. The files have to be manually deleted.

Also, the Macro Manager provides no way to manage a large number of Macros. There's just one alpha-numeric ordered list of Macros in the left column, with a buggy "rename" option. 

In addition to fixing the specific bug described in "steps to reproduce", we perhaps need a wiki Proposal for improving the Macro Manager.

Comment 1 Peter Sampson 2019-06-04 08:14:20 UTC

On W10  with 2.3.3 alpha and on macOS 10.14.5 with 2.3.3 after the rename there is no duplicate, just the correctly renamed macro

Comment 2 James Crook 2019-07-16 02:42:43 UTC

Bug 2160 addresses items 3 and 4 in comment #0 (which apply to all platforms).  So this bug is now JUST about the linux issue of 1 and 2 in comment #0

Comment 3 Steve Daulton 2019-07-16 04:53:25 UTC

(In reply to James Crook from comment #2)
James wrote:
> Bug 2160 addresses items 3 and 4 in comment #0 

I've not tested that fix yet, but that looks like a good fix, so I'm happy for this bug to be considered as points 1 and 2 only.

Comment 4 James Crook 2019-07-16 05:40:55 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/fb11eeaeddf27d327551660d59a4faf183453dd5

The bug was caused by Linux updating the list AFTER Audacity had modified it.  On Windows the list update happens before.

Additionally fixed an issue where the list of macros in the menu does not update on a rename.  That issue was all platforms.

Comment 5 Steve Daulton 2019-08-07 13:12:10 UTC

Works for me.