Bugzilla – Bug 2120
Spectral Selection Toolbar can be truncated when undocked
Last modified: 2021-02-16 10:23:37 UTC
Created attachment 826 [details] Truncated Spectral Selection toolbar The Spectral Selection Toolbar can be truncated when undocked when switching from the narrower width "Low and High Frequencies" to the normally wider "Center Frequency and Width". The Toolbar remains at what was the correct, narrower, width for "Low and High Frequencies" - and is thus truncated on the right. See attachment
Created attachment 827 [details] Spectral Selection toolbar with trailing white space A workaround is to re-dock the toolbar - whereby it regains its proper full width for "Center Frequency and Width". But if you then undock it again an switch to the narrower "Low and High Frequencies" the toolbar retains the fuller width and is padded right by trailing white space.
Happens on Mac as well as Win so assume All platforms
This is a regression on 2.1.3
DEVEL - FIX MADE Bug 2120 - Spectral Selection Toolbar can be truncated when undocked
I meant: DEVEL - FIX MADE https://github.com/audacity/audacity/commit/29b0e31ee6d0c8a52618add63e90d6b5ca979d6a
(In reply to James Crook from comment #5) Testing on W10 with audacity-2.3.3-alpha-305-2b15aa28cacf9f50722b054b31291ace85945b00 I have re-opened this with a residula 1) Reset Toolbars 2) View>Toolbars>Spectral Selection Toolbar 3) opens docked in lower tooldock (at proper width - Center Freq and width) 4) undock the toolbar - all OK 5) change from Hz to kHz 6) observe narrower toolbar but with incorrect narrow vacant white strip on right 7) change to semitones 8) observe toolbar is now wrongly truncated opn the right - loses the dropdown arrow 9) redock toolbar 10) observe toolbar is restored properly
Examining the residual, this also affects the selection toolbar, if you change time formats.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/529e1b2b389d778d86531c9fd9b09919a88943fe This fixes the residual, including fixing Selection Toolbar (when undocked).
Testing on W10 with audacity-2.3.3-alpha-307-0bd1beae9a92c9753b04c160c0dd649ddd13939d Testing the rsidual against the steps in my Comment #6 - I confirm this residual is fixed properly. And just to be sre I also retested agains the Steps to reproduce - all good. Looks to be properly fixed on Windows
Testing on macOS 10.14.5 Mojave with 2.3.3 Mac alpha jc005 of 01Aug19 As with Windows ... Testing the residual against the steps in my Comment #6 - I confirm this residual is fixed properly. And I also tested against the Steps to reproduce - all good. Looks to be properly fixed on Mac
Looks OK on Linux. Not yet tested on Mac.
*** Bug 2414 has been marked as a duplicate of this bug. ***
The residual in comment 6 still happens on Ubuntu 20.04.
Fix in: https://github.com/audacity/audacity/commit/3ecc571 Sorry for the retesting, but the residual was still happening on Linux. It "should" now be resolved there as well.
Created attachment 1087 [details] trncated Spectral Selection toolbar Tested on W10 with Audacity 3.0.0 182878c a) I still get a truncated toolbar 1) Reset toolbars 2) show Spectral Selection toolbar 3) float it 4) change to Low and High Frequencies 5) Observe smaller toolbar 5.1) sometimes shrinks to size 5.2) but sometimes with redundant white space on the right Following 5.1 correct resizing 6) change to Center Frequency and Width 7) Observe: truncated toolbar (see attachment)
Yepper, I see it too. Tested 2.4.2 on Windows to make sure it wasn't my fix that broke it. I'll investigate some more.
Try this one on for size: (oh, I'm SO funny... :-)) https://github.com/audacity/audacity/commit/37b36f5
(In reply to Leland Lucius from comment #17) > Try this one on for size: (oh, I'm SO funny... :-)) > > https://github.com/audacity/audacity/commit/37b36f5 The updated layout does seem to fit the bill :)
Tested on W10 and macOS 11.2.1 with Audacity 3.0.0 37b36f5 All seems good to go - retested a) with the original steps b) with my updated steps in Comment #15 c) "testing around"
