Bug 2122 – Screenshot tool: no way to exit using the keyboard

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2122 - Screenshot tool: no way to exit using the keyboard


Summary:	Screenshot tool: no way to exit using the keyboard

Status:	CLOSED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.3
Hardware:	Per OS All

Importance:	P3 Accessibility
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-06-06 12:34 UTC by Peter Sampson
Modified:	2019-08-09 10:31 UTC (History)
CC List:	7 users (show)

See Also:	98
Steps To Reproduce:	1) Tools > Screenshot 2) try to leave the dialog/window using the keyboard 3) Observe: you can't - the only way is to use the mouse
Release Note:	Group: TBP *The Screenshot tool window can only be closed by using the mouse. There is no keyboard way to exit the window, making this command poor for VI users.
First Git SHA:
Group:	---
Workaround:	None
Closed:	2019-08-09 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2019-06-06 12:34:35 UTC

In Screenshot too there no way to exit using the keyboard, you are forced to use the mouse on the window "X".

The lack of an exit button of the form "OK" or "Cancel" or "Exit" that can be navigated to from the keyboard is bad for "accessibility" for VI users.


See also Bug #98 "Debug Log window and Screenshot tools don't close on ESC"

Comment 1 Peter Sampson 2019-06-06 12:57:16 UTC

See also P4 ENH Bug #1598 "Enh: Improve GUI for Screenshot Tools"

Comment 2 James Crook 2019-07-16 08:26:56 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/26a0ffc0aecb018683f8d666422658aeda04cda7

This is a 'fix' just to close this bug, in case a fix for bug #1598 does not make it into this release.

Also added a help button for this mightily confusing dialog.

Comment 3 Peter Sampson 2019-07-17 04:03:27 UTC

(In reply to James Crook from comment #2)
Testing on W10 with audacity-2.3.3-alpha-290-20772c995d62e3552ae8432e6e3fbc5b65a94ed2

The new "Close" button works fine - but for VI users takes a *lot* of tabbing through to get to it - fortunately Shift+Tab will get you there in 2.

The new "?" help button is a good useful addition - tested and works OK

Note that you stll cannot use ESC to escape from this dialog

Comment 4 Peter Sampson 2019-07-25 07:45:30 UTC

Testing on macOS 10,14.5 with mac 2.3.3 alpha jc004 of 25Jul19

The new "Close" button works fine - but I don't appear to be able to tab through the buttons.

The new "?" help button is a good useful addition - tested and works OK

Note that, as with Windows, you stll cannot use ESC to escape from this dialog

Comment 5 Steve Daulton 2019-08-09 10:05:14 UTC

On Linux I can tab through the controls.
"Enter" when the Close button has focus, closes the window.
"Alt + C" closes the window.

"Esc" does not close the window.

Upshot: On Linux, the bug as described is fixed.
That the window cannot be closed with the Esc key could be classed as a residual issue (pretty low priority imo).

Comment 6 James Crook 2019-08-09 10:09:17 UTC

Then, reading comment 5, the bug as described is fixed.
CLOSED FIXED

Comment 7 Peter Sampson 2019-08-09 10:31:24 UTC

(In reply to Steve Daulton from comment #5)
>"Esc" does not close the window.

This is logged elsewhere as P5 Bug #98