Bug 2127 – Track deletion while in Record/Pause state crashes Audacity

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2127 - Track deletion while in Record/Pause state crashes Audacity


Summary:	Track deletion while in Record/Pause state crashes Audacity

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	2.3.3
Hardware:	Per OS All

Importance:	P1 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-06-17 05:55 UTC by Peter Sampson
Modified:	2019-07-09 11:19 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1) Record 2) Pause 3) Record (split line produced) 4) Pause 5) Delete track with to left "X" 6) Observe: Audacity crashes Alternative steps (tested on Linux) 1) Record 2) Stop 3) Record 4) Pause 5) Delete track with to left "X" 6) Observe crash (Segmentation fault - core dumped)
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-07-09 00:00:00

Flags:	petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2019-06-17 05:55:52 UTC

If the user tries to delete a track when Audacity is in Record-Paused state after restarting a previous pause of the recording with a record rather than a pause then Audacity will crash.

If the user tries the track deletion in Pause state after Step 2, the track is deleted.

If the user uses the (more normal) "Pause" at step 3, then at syep 6 the track gets deleted, no crash.

This is a regression on 2.2.2

Tested on W10 and Mac where it fails on both, so assume all platforms.

---------------------------------------------------

This raises a few basic questions.

1) should Record be alllowed as a way of un-pausing a paused recording?

2) should active track deletion be allowed when the track is active in a paused state ?
And note this affects playback as well as record.

3) should non-active track deletion be allowed when  in a paused state ?

Comment 1 Steve Daulton 2019-06-17 06:25:36 UTC

Alternative steps added.

Note that "Tracks menu > Remove Tracks" prohibits deleting tracks during paused recording.

For consistency, removing tracks with click to the track [X] should also be prohibited.

Comment 2 Paul L 2019-06-28 11:00:22 UTC

Fixed at
https://github.com/audacity/audacity/commit/c50acea3282eb3106c81f36c372e1556dfed092e

Comment 3 Peter Sampson 2019-07-04 12:57:05 UTC

Testing on W10 with audacity-2.3.3-alpha-280-6adb2abc98618ffaee43841bf229ec5b14e40ed6

At Step 6 there is now no crash and the track is deleted


Question 1 from comment #0
>1) should Record be allowed as a way of un-pausing a paused recording?

This is now longer the case - only Pause un-pauses  a paused recording

Comment 4 Peter Sampson 2019-07-04 12:59:40 UTC

Testing on macOS 10,14.5 with 2.3.3 alpha jc002 30Jun19

as with Windows

At Step 6 there is now no crash and the track is deleted

And only Pause un-pauses  a paused recording - not a further press of Record

Comment 5 Cliff Scott 2019-07-04 14:37:23 UTC

Testing on MacOS 10.13.6 with commit b2a2cf built July 4th.

Confirm no crash, BUT recording can be restarted with out unpausing if using keyboard shortcuts. Is this intentional? I would think this would be ok, but it is inconsistent with the mouse activated functions.

Comment 6 Steve Daulton 2019-07-09 11:19:39 UTC

Works for me. Closing as FIXED.