Bugzilla – Bug 2133
Silence Audio deletes MIDI notes
Last modified: 2019-07-09 11:06:03 UTC
MIDI is NOT AUDIO, so this behaviour is unexpected and destroys user data. When Note data is selected, users that are familiar with MIDI would expect a "Silence Audio" command to have no affect on the MIDI data. However, we "delete" (not even just "silencing" but completely remove) the selected MIDI data. It "could" be argued that "Silence Audio" should "silence" the selected section of the Note Track, for example by reducing velocity data to zero, but as there is currently no way to set velocity data, that would be a very bad idea at this time. This is a regression against Audacity 2.1.3. As the user may not have MIDI playback enabled (particularly for Linux users where MIDI playback is not audible by default), so this bug could destroy user data, and the user could easily not notice until it's too late.Hence P1.
Fixed at: https://github.com/audacity/audacity/commit/97f48c4326a01d3286886e0ebb0f994cf319063b
Testing on W10 with audacity-2.3.3-alpha-277-bdcb55467f725ad6e138a54da7e76244d3cc81eb with a selection in a Note track both Silence Audio and Trim Audio are grayed ot in the Menu and their buttons are grayed out in the Edit Toolbar - the commands are inoperable. Note that no error message is displayed to the user,
Testing on macOS 10.14.5 Mojave with alpha 2.3.3 jc002 of 30Jun19 Same as Windows with a selection in a Note track both Silence Audio and Trim Audio are grayed out in the Menu and their buttons are grayed out in the Edit Toolbar - the commands are inoperable. Note that no error message is displayed to the user,
Works for me (as described in comment #2). Closing as FIXED.
