Bugzilla – Bug 2141
Tabbing between labels now only works if the label track is selected
Last modified: 2019-07-09 11:14:07 UTC
David wrote by email >In released versions of Audacity you can tab between labels regardless of >whether the track is selected. Currently you can only do this if the track >is selected. This is a regression on 2.3.2 - maked as P1 as users are unlikely to "discover" the workaround
I have just tested this on various old versions of Audacity 2,3,2 2.3.0, 2.2.0 and 2.0.6 - and all cases the label track has to be focused for the tab to take effect. I suspect that this may be down to the fact that it is quite possible to have multiple label tracks and Audacity needs to know which on eto tab in So this looks like NOTABUG to me - but I'd like confirmation from other QA folk
I note that it state in the Manual: >When focus is on a label track as indicated by the yellow focus border: >TAB opens the next label for editing and places the editing cursor or selection >to correspond with that label >Shift + TAB opens the previous label for editing and places the editing cursor >or selection to correspond with that label.
I disagree that this is not-a-bug, because it is possible for a label track to be focused but not selected, and in that case TAB does not work, as manual says it should.
You can make the track focused but not selected by using arrow keys, and using ctrl+click on the TCP.
(In reply to Peter Sampson from comment #1) > I have just tested this on various old versions of Audacity 2,3,2 2.3.0, > 2.2.0 and 2.0.6 - and all cases the label track has to be focused for the > tab to take effect. It has to be focused, but not necessarily selected. The focused item is the item which normally interacts with keyboard input. (There are exceptions.) > > I suspect that this may be down to the fact that it is quite possible to > have multiple label tracks and Audacity needs to know which on eto tab in > > So this looks like NOTABUG to me - but I'd like confirmation from other QA > folk I don't understand how you've got to your conclusion. You haven't mentioned whether or not the track is selected.
(In reply to David Bailes from comment #5) >I don't understand how you've got to your conclusion. >You haven't mentioned whether or not the track is selected. If the label track is selected it gains focus - you can shift focus from a selected label track with the up down arrow keys,. As the Manual says - a label track has to be focused (for the tabbing to work) And as you, David, state >It has to be focused, but not necessarily selected. AHHH - but now I see what you mean (apologies for the confusion) 1) get audio track 2) add a couple of labels (focus is on label track, but track is not selected 3) use Tab - it works 4) Select the audio track 5) use tab 6) Observe it fails to work 7) use down arrow to sfft focus (but not selection) t label track 8) use tab 9) Observe it fails to work (THIS is the regression bug - it works on 2.3.2 and earlier) 10) either Select the label track, or just click in it 11) Tab now works
A fix at https://github.com/audacity/audacity/commit/bdcb55467f725ad6e138a54da7e76244d3cc81eb so that when a label track is focused, you can tab among the labels; whether or not the track is selected. But this will not "fix" the steps to reproduce as currently stated: "1) get some audio 2) add some labels 3) shift focus to audio track 4) use Tab to try to tab between labels 5) Observe: the tab does nothing"
Updated the Steps to reproduce
(In reply to Paul L from comment #7) Testing on W10 with audacity-2.3.3-alpha-277-bdcb55467f725ad6e138a54da7e76244d3cc81eb At Step 8 this now works properly And Step 10 continues to work properly
Testing on macOS 10.14.5 Mojave with alpha 2.3.3 jc002 of 30Jun19 As with Windows: At Step 8 this now works properly And Step 10 continues to work properly
Works for me. Closing as FIXED.
