Bug 2160 – Shipped macros are not protected against edits.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2160 - Shipped macros are not protected against edits.


Summary:	Shipped macros are not protected against edits.

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Other
Version:	2.3.3
Hardware:	Per OS All

Importance:	P4 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-07-16 02:16 UTC by James Crook
Modified:	2019-08-02 11:56 UTC (History)
CC List:	4 users (show)

See Also:
Steps To Reproduce:	1) Select either of the shipped Macros "Fade Ends" or "MP3 Conversion" 2) Modify the macro by adding or deleting commands. Observe A: Macro editing is allowed for these built in commands, even though rename and remove are greyed out.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-07-23 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ flyer185: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Crook 2019-07-16 02:16:23 UTC

Split from Bug 2199

Comment 1 James Crook 2019-07-16 02:17:01 UTC

I mean Bug 2119

Comment 2 James Crook 2019-07-16 02:40:26 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/d5dceb240f6e750867f73ddc90392c2cc72fe979

It turned out that the actual problem was that the 'Defaults' button was not obvious.  It is now called 'Restore' and is with the Remove and Rename buttons.

Comment 3 Peter Sampson 2019-07-16 03:32:24 UTC

It could be regarded as a good, and valuable, "feature" that the user can modify the shipped Macros.  Especially since we have no Export/Import for Macros  - so copying the Fade Ends to modify it is not straightforward

It is possible to restore the at any time to their shipped state by selecting the Macro and using the Defaults button

Comment 4 Cliff Scott 2019-07-16 23:01:05 UTC

Looks good on MacOS 10.13.6 Commit a07b16. The macros are editable, but can be restored to original if desired.

Comment 5 Peter Sampson 2019-07-17 03:53:19 UTC

Testing on W10 with audacity-2.3.3-alpha-290-20772c995d62e3552ae8432e6e3fbc5b65a94ed2

The shipped Macros are still *not* protected against edits - so strictly speaking this bug, as staed in title and steps, is not fixed.

I observe the "Defaults" button replaced by "Restore" - whuch I think is preferrable, a good change

However what we have now night be considered good desired behaviir as t lets user modify the shipped Macros abd easily restore them.

But for now until we decide I am going to mark this "?" on Windows

Comment 6 Steve Daulton 2019-08-02 11:56:17 UTC

(In reply to Peter Sampson from comment #5)
Peter wrote:
> The shipped Macros are still *not* protected against edits - 
> so strictly speaking this bug, as staed in title and steps, is not fixed.
> ...
> However what we have now night be considered good desired behaviir as t
> lets user modify the shipped Macros abd easily restore them.

I'm happy with the current behaviour, and would argue that the shipped macros *are protected* as they can be restored at the click of a button.