Bugzilla – Bug 2191
Audacity throws warning dialog on opening project if it contains silent blockfile(s)
Last modified: 2019-08-28 07:35:37 UTC
Created attachment 851 [details] Test project Attempting to open the attached project throws an error message: "Project check read faulty Sequence tags." The default behaviour is to close the project. The project opens correctly in Audacity 2.2.1.
After a bit more investigation, the problem appears to be that Audacity 2.3.3 is incorrectly flagging an error when the project contains one or more silentblockfile. Example (entirely with Audacity 2.3.3 alpha): 1) Launch Audacity 2) Generate 10 seconds silence 3) Save the project 4) Close and restart Audacity 5) Try to open the project that was saved in step 3. Note the error message.
Updated summary.
Steve you have logged this as a regression - on which version is it so? Not 2.3.2 as you steps in Comment #1 fail in that as well as 2.3.3 alpha
(In reply to Peter Sampson from comment #3) On Linux I don't see the problem in 2.3.1 or 2.3.2.
Created attachment 856 [details] Warning message re silence Well for me testing on W10 it's a regression on 2.3.1 Testing using your steps from Comment #1 On 2.3.2 and 2.3.3 when I reopen the project at Step 5 I get the attached warning (not error) message. If I then select the non-default option >Continue with repairs noted in log ... The project opens with 10 seconds of silence With 2.3.1 at Step 5 the project just opens with 10 seconds of silence and no warning message. Log to follow
Created attachment 857 [details] Log file from warning dialog in 2.3.3 This is the logfile that 2.3.3 produced
On macOS10.14.6 wit alpha jc007 it is a regression on 2.3.2 Both 2.3.2 and 2.3.1 open the project without the warning. But 2.3.3 pops the waring - and annoyingly if you select show log, the log widow opens behind the warning making it difficult to read. And as the warning is so wide it's had to move the log window to a readable position.
Just retested on 2.3.2 on W10 just to re-check (after the Mac and Linux tests) and now this too works properly without the warning. So this is a regression on 2.3.2
Also tested on W10 with the test project from the attachment. 2.3.2 opens it fine with no warning 2.3.3 gives the warning - but if I then select the non-default option >Continue with repairs noted in log ... The project opens with 10 properly And since the project opens OK and the message is only a warning (albeit a bit dire) - this is surely only a P1 because we (wearing QA hat) *really* do not want to release with this.
Note that the project still works as the log file shows that it replaces the missing gaps with silence >16:37:57: Warning: Gap detected in project file. Replacing missing block file with silence. But you also get >Warning: Track Niamh's request had error reading clip values from project file.
int status = ::ProjectFSCK(dirManager, err, false); in ProjectFileManager.cpp is being passed err of true. In Sequence.cpp void Sequence::HandleXMLEndTag(const wxChar *tag) { if (wxStrcmp(tag, wxT("sequence")) != 0) return; // Make sure that the sequence is valid. // First, replace missing blockfiles with SilentBlockFiles for (unsigned b = 0, nn = mBlock.size(); b < nn; b++) { SeqBlock &block = mBlock[b]; if (!block.f) { block.f is coming out false, for a silent blockfile, which is why err is true. I have not investigated further than this. Assigned to Paul as it is most likely from recent refactorings in this area, since the problem per comment #9 apparently is not in 2.3.2.
Bisected to ca0fb190e6a98a8c44c8c2ed7fe2422c47a22845
Fixed at https://github.com/audacity/audacity/commit/efc95152d5e5ce3cc11a9ca38c81a57e788a9360
MacOS 10.14.6, Commit efc951 Works here with the Test Project file and also the sequence in Comment #1. No error messages seen.
(In reply to Paul L from comment #13) Testing on W10 with audacity-2.3.3-alpha-323-80ef42433899446f6fc11701a961fb0a5f66290e Works here with the Test Project file and also the sequence in Comment #1. No error messages seen.
