Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2192 - Linux: Many effects (Repair, Paulstretch, Reverb) much slower
Linux: Many effects (Repair, Paulstretch, Reverb) much slower
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Built-in FX
2.3.3
Per OS Linux
: P1 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-08 10:27 UTC by Steve Daulton
Modified: 2019-10-15 12:31 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
1) Apply "Repair" effect to a selection of the maximum 128 samples. 2) Observe: on Audacity 2.3.3 it is very much slower than previous versions.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2019-10-12 00:00:00
stevethefiddle: Regression+
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Daulton 2019-08-08 10:27:04 UTC
Xubuntu 18.04 64-bit, Audacity 2.3.3 84d57170054857ff97919c7a2c9cf33b1f2c6053

Tested with debug and non-debug builds.
Time taken for the Repair effect on a selection of around 120 samples, is around 7 to 9 seconds. In previous versions the effect was almost instant.
Comment 1 Peter Sampson 2019-08-08 11:22:13 UTC
Testing on W10 with latest alpha audacity-2.3.3-alpha-315-84d57170054857ff97919c7a2c9cf33b1f2c6053

A repair of 120 samples is almost instant.   WORKSFORME



@Steve: you have marked this as a regression - but on which Audacity version?
Comment 2 Steve Daulton 2019-08-08 11:30:16 UTC
Regression against Audacity 2.2.1 (The Ubuntu 18.04 LTS release version).

Audacity 2.3.2 and 2.3.1 have the same problem.
Comment 3 James Crook 2019-08-10 07:36:06 UTC
Per Steve's email not just repair, but also Paulstretch 5x slower, Reverb 4x slower on Linux (vs 2.2.1).  Raising from P2 tp P1 and changing title.
Comment 4 Peter Sampson 2019-08-10 12:28:20 UTC
At Robert's suggetstion I tested with the full 128 samples - and on both Win and Mac with latest alphas the Repair effect is almost immediate.
Comment 5 Peter Sampson 2019-08-10 12:33:49 UTC
(In reply to Peter Sampson from comment #4)
Testing on W10 with audacity-2.3.3-alpha-315-84d57170054857ff97919c7a2c9cf33b1f2c6053 and 2.3.3

Testing on a five minute stereo song Reverb and Paulstretch show the same timings on 2.3.2 and latest alpha 2.3.3

a) Reverb - 2 seconds

b) Paulstretch - 1min 16secs
Comment 6 Peter Sampson 2019-08-18 09:48:53 UTC
(In reply to Peter Sampson from comment #5)
And testing on W10 with 2.2.1 (where Steve cites the regression)

a) Reverb - 2 seconds (same as 2.3.3 and 2.3.2)

b) Paulstretch - 1min 38secs (22 seconds slower than 2.3.3 and 2.3.2)

=> later Audacities show an improvement for Paulstretch
Comment 7 Steve Daulton 2019-09-29 16:30:33 UTC
Testing on a five minute stereo song, default settings for effects, Linux non-debug (release) build:

Audacity 2.2.1
Reverb: 3 seconds
Paulstretch: 56 seconds

Audacity 2.3.3 alpha (5d4c884)
Reverb: 9 seconds
Paulstretch: 322 seconds


I also tested the new "Filter Curve" compared to "Equalization":

Audacity 2.2.1
Equalization (Bass boost): < 1 second

Audacity 2.3.3 alpha (5d4c884)
Filter Curve (Bass Boost): 10 seconds
Comment 8 Steve Daulton 2019-10-11 06:01:29 UTC
Fix made: https://github.com/audacity/audacity/commit/b2e7350587e

Sets the default optimization level for release builds to -O2, though allowing this to be overridden with CFLAGS / CXXFLAGS.
When the --enable-debug option is selected, optimizations are overridden by '-O0 -g'.

Note that effects will be slow when Audacity is built with the --enable-debug option, because optimizations have been disabled for debugging. If debugging symbols are required with some optimizations enabled, use CFLAGS / CXXFLAGS to set the optimization level and "-g" for debugging symbols and do not use the configure option "--enable-debug".
Comment 9 Peter Sampson 2019-10-12 06:02:07 UTC
As Steve is the original looger of this bug and is the key Linux QA tester - I am assuming that he is happy with the results of this fix.

And althought it is not usual for us to close a bug off when tested by the person who committed the fix - in this case I sahall make an exception an close this as RESOLVED
Comment 10 Peter Sampson 2019-10-15 10:09:21 UTC
REOPENED as this apperas to be still under discussion
Comment 11 Steve Daulton 2019-10-15 12:25:08 UTC
(In reply to Peter Sampson from comment #10)
I believe this bug is now solved. However, there is a residual that is currently unresolved. That residual is logged as bug 2228.