Bug 2199 – crash after attempting to export as OGG at very high sample rate

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2199 - crash after attempting to export as OGG at very high sample rate


Summary:	crash after attempting to export as OGG at very high sample rate

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Formats
Version:	2.3.3
Hardware:	Per OS All

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-08-15 15:21 UTC by Steve Daulton
Modified:	2019-08-25 08:28 UTC (History)
CC List:	3 users (show)

See Also:
Steps To Reproduce:	1) Set the project rate to 384 kHz 2) export as OGG. 3) There is an error dialog that says: "Unable to export". 4) Observe: On clicking the "OK" button, Audacity crashes.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-08-25 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS- petersampsonaudacity: Test‑OK‑Win+

Attachments
backtrace (5.60 KB, text/plain) 2019-08-15 15:21 UTC, Steve Daulton	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2019-08-15 15:21:41 UTC

Created attachment 855 [details]
backtrace

Reported and tested on Linux.

The Vorbis specification says that sample rates up to 192 kHz are supported.
On attempting to export at a much higher sample rate, say 384 kHz, the export fails with the error: "Unable to export".

On clicking "OK" on the error dialog, Audacity crashes.

Also, a useful enhancement would be a more meaningful error message, such as including "sample rate too high".

Backtrace attached.

Comment 1 Steve Daulton 2019-08-15 15:30:07 UTC

This is arguably P1, but I've set it as P2 because of (a) the rarity of people using such high sample rates, (b) it makes no sense to export in OGG format at such high sample rates as OGG has a cut-off at around 20 kHz.

Comment 2 Steve Daulton 2019-08-15 15:32:41 UTC

(In reply to Steve Daulton from comment #1)
> OGG has a cut-off at around 20 kHz.

Not true. OGG has a cut-off of around 20 kHz at normal "quality" settings, but at highest quality it  can go right up to 96 kHz.

Comment 3 James Crook 2019-08-24 15:47:48 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/c32b92c37763dbf9a9bab0eaf889b1e183219273

Comment 4 Peter Sampson 2019-08-25 08:24:15 UTC

Testing on W10 with audacity-2.3.3-alpha-334-c32b92c37763dbf9a9bab0eaf889b1e183219273

At Step 3 I still get the error message (I assume this is expected behavior)

But at Step $ Audacity no longer crashes.

Looks to be fixed

Comment 5 Peter Sampson 2019-08-25 08:28:01 UTC

And as Steve requested in Comment #0 the error message has been made more helpful