Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2212 - Mac: Keyboard tabbing in Timer Record stuck in left hand panel.
Mac: Keyboard tabbing in Timer Record stuck in left hand panel.
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.3.3
Mac macOS
: P2 Accessibility
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-06 09:22 UTC by Cliff Scott
Modified: 2020-08-29 11:11 UTC (History)
8 users (show)

See Also:
Steps To Reproduce:
1. Open the Timer Record function from Transport/Recording/Timer Record. 2. With tab key try to get from the left hand times panel to the right hand panel. 3. Note the tab continues to cycle through the different time settings, but never goes to the right hand panel to set the other options.
Release Note:
Group: Accessibility *On Mac, Keyboard tabbing in Timer Record keeps you stuck in left hand panel
First Git SHA:
Group: ---
Workaround:
This works on Windows
Closed: 2020-08-29 00:00:00
petersampsonaudacity: Accessibility+
petersampsonaudacity: Regression+
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cliff Scott 2019-09-06 09:22:10 UTC
See steps to reproduce.
Comment 1 Peter Sampson 2019-09-06 09:54:17 UTC
For me with 2.3.3 alpha jc008 it gets stuck in the right hand panel - stuck on the "Enable Automatic Export" box.

Works fine on W10 with audacity-2.3.3-alpha-344-a77a3ab2ac9620666083e17b420f4edc931a3d0f
Comment 2 Peter Sampson 2019-09-06 10:19:33 UTC
This is a regression on 2.3.1 - thus raising it to P2
Comment 3 Leland Lucius 2020-03-02 14:54:03 UTC
I'm pretty sure this is normal on the Mac.  Try tabbing here as well:

Screenshot dialog
Preferences -> Devices
Preferences -> Quality

Basically, any control that doesn't have a field where you can type something in, will be "ineligabale" for tabbing into.

For me, the same thing happens in v2.3.1.
Comment 4 David Bailes 2020-03-03 05:33:39 UTC
(In reply to Leland Lucius from comment #3)
> I'm pretty sure this is normal on the Mac.  Try tabbing here as well:
> 
> Screenshot dialog
> Preferences -> Devices
> Preferences -> Quality
> 
> Basically, any control that doesn't have a field where you can type
> something in, will be "ineligabale" for tabbing into.
> 
> For me, the same thing happens in v2.3.1.

But if you in system preferences > keyboard > accessibility, you set ”Use keyboard navigation to move focus between controls”, then you should be able to Tab to all controls, not just text boxes and lists.
https://support.apple.com/en-gb/HT204434

Last time I looked at this, with the above option set, the bug described was present.
Comment 5 Leland Lucius 2020-03-03 09:49:57 UTC
(In reply to David Bailes from comment #4)
> (In reply to Leland Lucius from comment #3)
> > I'm pretty sure this is normal on the Mac.  Try tabbing here as well:
> > 
> > Screenshot dialog
> > Preferences -> Devices
> > Preferences -> Quality
> > 
> > Basically, any control that doesn't have a field where you can type
> > something in, will be "ineligabale" for tabbing into.
> > 
> > For me, the same thing happens in v2.3.1.
> 
> But if you in system preferences > keyboard > accessibility, you set ”Use
> keyboard navigation to move focus between controls”, then you should be able
> to Tab to all controls, not just text boxes and lists.
> https://support.apple.com/en-gb/HT204434
> 
> Last time I looked at this, with the above option set, the bug described was
> present.

And that's what I get for being away for so long.  Sorry about that David.  I'll take another look.
Comment 6 Leland Lucius 2020-03-07 20:24:49 UTC
Yeppers, definitely messed up. I went back to v2.2.2 and, while it doesn't get stuck in the left pane like Cliff sees, it does something similar to what Peter is seeing...get stuck on the checkbox.

Peter, I believe that if you were to backtab after getting to the "Enable Automatic Export?" checkbox, you'll see it proceed to the "Enable Automatic Save?" checkbox and, if you keep pressing it, you'll eventually get to the Help button and stop there.  Tabbing then will again reverse the cycle.

So, we definitely have an undesired terminus.

You should try backtabbing in Preferences...totally borks up there.
Comment 7 Leland Lucius 2020-03-08 03:36:31 UTC
The current behavior bisects to:

https://github.com/audacity/audacity/commit/75e44df43d13d73b044736c2bbb130075b31cfba

But, that's not the only problem.  If you try 2.3.1 which predates that commit, you can create something similar by clicking one of the checkboxes.  Tabbing will then stop at some point.

Digging deeper...
Comment 8 David Bailes 2020-03-08 05:10:08 UTC
(In reply to Leland Lucius from comment #7)
> The current behavior bisects to:
> 
> https://github.com/audacity/audacity/commit/
> 75e44df43d13d73b044736c2bbb130075b31cfba

The narrator screen reader on Windows only reads the names of group boxes after the change in this commit. You probably weren't thinking or reverting this commit, but please don't!

> 
> But, that's not the only problem.  If you try 2.3.1 which predates that
> commit, you can create something similar by clicking one of the checkboxes. 
> Tabbing will then stop at some point.
> 
> Digging deeper...
Comment 9 Leland Lucius 2020-03-08 14:08:56 UTC
(In reply to David Bailes from comment #8)
> (In reply to Leland Lucius from comment #7)
> > The current behavior bisects to:
> > 
> > https://github.com/audacity/audacity/commit/
> > 75e44df43d13d73b044736c2bbb130075b31cfba
> 
> The narrator screen reader on Windows only reads the names of group boxes
> after the change in this commit. You probably weren't thinking or reverting
> this commit, but please don't!
> 

Noper, not reverting.  It really is supposed to work the way Paul says in the commit.

I'm pretty sure there's a bug in the wxWidgets wxControlContainer::HandleOnNavigationKey method, which decides the next control to get focus.  I think it's stopping prematurely because of the disabled controls.

I can actually get full circular navigation to work simply by never disabling the "After Recording Completes" combo.  And that's a "possible" (but icky) fix for the immediate problem.  If neither of the checkboxes are check, the list would only contain "Do nothing", otherwise it would include the other options as well.

But, the real bug needs to be found otherwise this could just happen again in the future.
Comment 10 Peter Sampson 2020-08-29 11:11:17 UTC
Testing on macOS with Audacity 3.0.0 c17b804

I now find I can tabe from the left pane to the right pane and back again with Tab/Shift+Tab