Bug 2225 – No error message when trying to delete with no selection

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2225 - No error message when trying to delete with no selection


Summary:	No error message when trying to delete with no selection

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.3
Hardware:	PC Windows 10

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-10-05 05:12 UTC by David Bailes
Modified:	2019-10-10 12:42 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1. With one or more tracks, but no selection. 2.Edit > Delete. 3. Nothing happens and no error message. Note that you do get an error message if you press Delete or Backspace.
Release Note:	TBP
First Git SHA:
Group:	---
Workaround:	Make a selection prior to making a Deltion
Closed:	2019-10-10 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Bailes 2019-10-05 05:12:33 UTC

See steps to reproduce

Comment 1 David Bailes 2019-10-05 05:21:45 UTC

Fixed:
https://github.com/audacity/audacity/commit/cff0011ee40dba6aa2e749ab99ea4efa57736796

Comment 2 Peter Sampson 2019-10-05 10:12:26 UTC

Testing on macOS 10.14.6 with 2.3.3 alpha jc010 of 05Oct19
this now weeks on Mac with the error message displayed
>Select the audio for Delete to use ...


Testing on W10 with audacity-2.3.3-alpha-352-98f495a4858b98198f66f4c956fb4730bf13a390

On Windows this still does not work - no error message is displayed - and I observe another oddity here: the null Delete (not blocked by the error message) is added to the Undo stack

Accordingly reopened due to the windows failure

Comment 3 David Bailes 2019-10-05 10:20:18 UTC

(In reply to Peter Sampson from comment #2)
> Testing on macOS 10.14.6 with 2.3.3 alpha jc010 of 05Oct19
> this now weeks on Mac with the error message displayed
> >Select the audio for Delete to use ...
> 
> 
> Testing on W10 with
> audacity-2.3.3-alpha-352-98f495a4858b98198f66f4c956fb4730bf13a390
> 
> On Windows this still does not work - no error message is displayed - and I
> observe another oddity here: the null Delete (not blocked by the error
> message) is added to the Undo stack
> 
> Accordingly reopened due to the windows failure

You appear to be testing with an old commit. You need to test with cff0011ee40dba6aa2e749ab99ea4efa57736796 or later.

Comment 4 Peter Sampson 2019-10-05 11:12:03 UTC

(In reply to David Bailes from comment #3)
OOPs yes, sorry David  

I don't know how that happened - I was sure I'd downloaded James' latest Appveyor build - but anyway …

Testing on W10 with audacity-2.3.3-alpha-353-cff0011ee40dba6aa2e749ab99ea4efa57736796

Yes indeed the error message now appears when you try to Delete audio with no selection present - I tested with both settings for the "Select all audio, if selection required" preference.

------------------------------------------------------

Interestingly if you try to do the same with just a label track or just a Note track present you do not get an error message, but instead the Delete command (along with Cut and Copy) in the Edit menu are grayed-out and unavailable.