Bugzilla – Bug 2237
Equalization effects have no Import or Export for curves
Last modified: 2020-02-20 05:25:57 UTC
Created attachment 874 [details] Equalization effect in 2.3.2 With 2.3.3 we are replacing the old 2-part Equalization with two independent (non-interacting) effects: Filter Curve and Graphic EQ. As part of this we removed the old "Save/Manage Curves" button as it did not play nicely with (and indeed conflicted with) our newer "Manage" button that we use consistently for all effects. Under the Manage button there are two menu commands for Import and Export (for custom curve management and sharing). As of now these buttons are grayed-out and inoperable (basically not yet implemented). This creates a regression as with the old "Save/Manage Curves" button in Equalization Import and Export of curves was available. However note carefully that under the Manage button in Filter Curves and Graphic EQ there are options for managing user presets for curves - but these are store in pluginsettings.cfg and are not thus exportable or readily shareable. The upshot of this is: a) the user can manage custom curves b) the user cannot export curves to share with friends or move curves to another computer c) the user cannot import the extra curves we publish on the Wiki If there were no custom curve management of curves at all this would be P1 - but as there is and the regression is a lack of sharing then I'm prioritizing this as P2
Created attachment 875 [details] Filter Curve effect in 2.3.3 Filter Curve effect in 2.3.3 showing custom curve management options
Note that the lack of Import and Export under the Manage button is common to all effects that carry the manage button It's just that it's more serious for these two due to the regression that has been created with the removal of the "Save/Manage Curves" button and its attendant Export and Import.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/83c294c84418ec52fc91a92013970c4655af3dc0
(In reply to James Crook from comment #3) Super :-) Works for me on Linux.
Now all we need is a clever Python script to convert from old XML files to new scritping parameter ones...
Testing on W10 and macOS 10.15.3 with Audacity 2.4.0 1d9aa20 The Import and Export works fine for both EQ effects. There are some residuals though: 1) Import/Export works for all effects (not just EQ effects) - and right now you can import the .txt file with parameters from a different effect - an no error message is thrown. 2) Importing non-EQ parameter settings into and EQ effect will flatten the curve. 3) Importing EQ parameter settings into non-EQ is silently ignored. 4) because of the above you can cross-import between the two EQ effects. It would be good to try to retain this as some user may well find that useful.
I have raised the residuals as separate bugs. As this bug as written now works I shall close this as FIXED
