Bugzilla – Bug 2246
Multi-view: using Undo loses the split view
Last modified: 2020-01-05 10:56:38 UTC
Using any Undo when the user has a split view present will result in the split view being lost with the track view being reverted to Waveform - thus losing the user's careful split setting. This is probably a close cousin of Bug #2243
Also happens if you: 1) record a track 2) split the view while recording 3) Stop 4) Undo 5) Observe: track is removed 6) Redo 7) Observe track is restored 0 but in simple 100:0 unsplit waveform view
Testing on W10 with audacity-2.4.0-alpha-363-5459a7bf27259b4cadae4e5bac65b28999d5b940 Undo and Redo now leave the spit track as it should be - OK on W10
Tested with commit 5459a7 macOS 10.14.6 Following the steps to reproduce this bug fails as the Undo undoes the split as well as the effect. Redo bring both the split view and the effect results back. Since the Split View is the last thing done I expected it to undo the Split View, but it undoes both and apparently the intent was not to undo the Split View. Doing the split before the effect works as expected, i.e. only the effect is undone. The split view remains.
I passed this yesterday on the basis of testing done while testing 2243 Today, following the Steps to reproduce on W10 I confirm Cliff's findings on Mac - so I am reopening this bug. -------------------------------------------------------- Curiously if at Step 3 you just resize the track (with no split) - either making it larger or smaller - or changing the relative size of the two channels in a stereo track). Than at step 5 you observe that the track is incorrectly reverted to its default size - works the same for Waveform and Spectrogram view. Should we be logging this as a separate bug ?
(In reply to Peter Sampson from comment #4) The re-size issue is not a regression caused by Split-view changes - it is the same on 2,3,3 and 2.0 - so we have had this for a long time - so I will log it as a separate bug
(In reply to Peter Sampson from comment #5) Resize issue logged as P2 Bug #2252
I insist that a fix is made and this issue should close. What Cliff reports and comment 3, is not a "bug" with split views but rather is consistent with how Audacity handles all kinds of view-only changes. It has been the case for a long time that changes only in view settings do not create separate items in Undo history, but rather the effect is added to the most recent item and undoes/redoes with it thereafter. This is so not only for split views and resizings, but also changes of selection, zooming in and out either vertically or horizontally, changes of vertical view scale, and so on.
Steve wrote email: >I think it's arguable whether this is the "best" behaviour, but it's how >we have handled track view changes for a very long time, so it's not a "bug".
