Bug 2351 – Selection toolbar displays incorrect number of samples beyond 2^31 -1

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2351 - Selection toolbar displays incorrect number of samples beyond 2^31 -1


Summary:	Selection toolbar displays incorrect number of samples beyond 2^31 -1

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.4.0
Hardware:	Per OS Linux

Importance:	P4 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-03-10 07:07 UTC by Steve Daulton
Modified:	2021-02-14 13:37 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1) Generate 14 hours of silence, 44100 sample rate. 2) Select the first 13h 31m 35.774s 3) Zoom in to see samples 4) Select "Start and End" and "samples" as the display format in the Selection Toolbar. 5) Slowly adjust the selection left and right, and observe the number of samples displayed in the "End" time. 6) Note that beyond (2)147483647 (the "2" is not visible), the number of samples jumps to 147483483 and does not increase.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2021-02-14 00:00:00

Flags:	stevethefiddle: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2020-03-10 07:07:44 UTC

Tested on Linux only.

When the time format in the Selection Toolbar is set to "samples", time values greater than 2147483647 samples (about 13h 31m 35.774s at 44100 Hz sample rate) are displayed as 147483483.

This is a regression against Audacity 2.2.1 (I've not tested more recent old versions).

Comment 1 Leland Lucius 2021-02-13 08:51:28 UTC

I believe this has been fixed.

Comment 2 Peter Sampson 2021-02-13 14:01:18 UTC

Testing on W10 and macOS 11.2.1 Bug Sur with Audacity 3.0.0 b928e7e

This looks to be fixed to me on both platforms

Comment 3 Steve Daulton 2021-02-13 16:10:14 UTC

I'm still seeing this issue with commit 7428c61060 on Xubuntu 18.04.

Easiest way to see the problem:

1) Generate 14 hours of silence, 44100 sample rate.

2) Select "Start and End" and "samples" as the display format in the Selection Toolbar.

3) Zoom in as far as possible

4) Jump to the end of the track.

5) "Ctrl + A" (select all)

6) Observe the "End" time in the Selection toolbar: 222,640,640 samples

7) Shift + Click and drag the end of the selection to the left.

8) Observe the "End" time in the Selection toolbar goes down to 222,640,639 samples, but does not count down - it appears to be stuck at 222,640,639.

It does "eventually" count down to 222,640,638, but not until you have dragged to 1000 samples to the left.

Comment 4 Steve Daulton 2021-02-13 16:11:52 UTC

(In reply to Steve Daulton from comment #3)
14 hours at 44100 Hz is actually 2,222,640,000 samples, not 2,222,640,640

Comment 5 Peter Sampson 2021-02-13 16:52:19 UTC

(In reply to Steve Daulton from comment #3)
I see what you mean

Comment 6 Leland Lucius 2021-02-13 18:10:39 UTC

Yep, I see it here too, but mine drops to 222,639,639.

Comment 7 Leland Lucius 2021-02-13 18:43:34 UTC

Fix in:

https://github.com/audacity/audacity/commit/d21b13a

Comment 8 Peter Sampson 2021-02-14 12:05:37 UTC

Tested on W10 with Audacity 3.0.0 5f68102

a) this now works properly with the end sample-count decreasing as the selection decreases

b) as per Steve's Comment #4 - the end point of the 14 hours is now 2,222,640,000 samples

Comment 9 Peter Sampson 2021-02-14 12:08:25 UTC

Tested on macOS 11.2.1 Bug Sur with Audacity 3.0.0 5f68102

a) this now works properly with the end sample-count decreasing as the selection decreases

b) as per Steve's Comment #4 - the end point of the 14 hours is now 2,222,640,000 samples

Comment 10 Steve Daulton 2021-02-14 13:37:24 UTC

Also working fine on Linux.
Thanks Leland - "Fixed".