Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2368 - Wrong results in effects when clip boundaries don't correspond across channels
Wrong results in effects when clip boundaries don't correspond across channels
Status: CLOSED WORKSFORME
Product: Audacity
Classification: Unclassified
Component: Multiclip
unspecified
Per OS Other
: P4 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-22 07:27 UTC by Paul L
Modified: 2020-04-08 16:57 UTC (History)
4 users (show)

See Also:
Steps To Reproduce:
I can demonstrate this with Reverb, which I think is the only built-in effect showing this problem, but it may also be demonstrable with third-party plug-ins (AudioUnits, VST, Vamp, etc.) 1) Record some seconds of quiet, then a hand-clap, as mono. 2) Duplicate the track. [ (3) Select an initial quiet portion of the duplicate, and split-cut with alt+ctrl+K. ] 4) Make stereo track. 5) Select all and apply Reverb effect with default settings. (In particular, Stereo Width is 100%. This effect does not compute the channels independently of each other.) 6) View in spectrogram. 7) Observe the difference with and without step 3. When some of the right channel is deleted, some of the reverb of the clap appears in the left channel BEFORE the clap!
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2020-04-08 00:00:00
petersampsonaudacity: Test‑OK‑Win?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul L 2020-03-22 07:27:15 UTC

    
Comment 1 Paul L 2020-03-22 07:59:47 UTC
This bug is probably as old as multi-clip, but did not affect any built-ins besides Reverb.

Quick fixed at
https://github.com/audacity/audacity/commit/210fc288638f284b52ea64c7a20eee959b78db3c
Comment 2 James Crook 2020-03-22 08:21:06 UTC
Paul,

Please give some guidance in these comments as to what needs testing after these changes.  Which effects?  Does only stereo need testing?  What might have inadvertently gone wrong as a result of this fix (e.g. clip lines in wrong place, trunc silence failing where silences are different in channels L and R).  Does VAMP need testing too after these changes?

Also please give proper steps to reproduce.
Comment 3 Paul L 2020-03-25 20:38:27 UTC
(In reply to James Crook from comment #2)

Are my given steps to reproduce not sufficient?

I explain that Reverb alone among built-in effects may show the problem, but it might also be reproducible in third-party plug-in effects such as VST.
Comment 4 James Crook 2020-03-26 04:25:47 UTC
There are two step 3's.  I think I understand the instructions now after re-reading several times.  Thanks.
Comment 5 Peter Sampson 2020-03-26 05:50:26 UTC
(In reply to James Crook from comment #4)
>There are two step 3's.

I have fixed the steps numbering and tidied up the steps
Comment 6 Peter Sampson 2020-03-30 09:10:41 UTC
Testing on W10 with Audacity 2.4.0 4b76af5

Following the steps an this latest alpha I see no difference btween with and without Step 3 - and I can hear no difference.

But testing on 2.3.3 I get the same clean results

Paul wrote in the steps:
>When some of the right channel is deleted, some of the reverb of the 
>clap appears in the left channel BEFORE the clap!

I just don't hear that not  with 2.4.0 or with 2.3.3

So unless I'm doing this wrong it WORKS-FOR-ME
Comment 7 Steve Daulton 2020-04-08 16:37:10 UTC
I can't reproduce this in any version of Audacity.
I've even tested with commit 8eee265c382e9ecc8a1ff81629f98e49b89eaf43
(the commit immediately before the "fix").

If there is / was a problem, we need more precise steps to reproduce it.
Comment 8 James Crook 2020-04-08 16:57:32 UTC
Based on Steve and Peter's testing, and my comment #2 closing as WORKS FOR ME.

Can always open a new bug if the fix broke something.