Bugzilla – Bug 2408
A region label gets split on inserting audio when Sync-lock is turned on
Last modified: 2020-05-31 12:51:42 UTC
Created attachment 967 [details] Split region label bug When sync-lock is on, if you insert audio into the rage of a region label a) the label is split into two separate labels b) both labels have exactly the same text c) only the original audio is "labelled" d) the inserted audio is unlabelled Expected behavior: the range label should remain a single label ad should be extended to encompass the original audio and the inserted audio, this to maintain track synchronization as per the "on" Sync-lock setting. Note that it is quite tricksy to accurately restore the two labels to be a single label of the required length - doable but takes a fair few steps (if you want or need to maintain positional accuracy). This was originally reported user mafg1953 on the Forum: https://forum.audacityteam.org/viewtopic.php?f=46&t=110497&p=393106 This does not appear to be a regression, rather it is long-standing behavior ------------------------------------------------- This does not affect audio insertion within the range of a Region label when Sync-lock is off (default Audacity setting)
I have graded this as P3 but I think it is marginal P2
>I have graded this as P3 but I think it is marginal P2 I upgraded this to P2 - the lack of proper observance of the sync-lock, plus the tricksiness involved in the user correcting this warrant P2 IMO
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/d6f8410d566527f10ae697c47fe34fdc81b09116 This fixes the steps to reproduce, but I am a bit concerned it may have undesirable consequences when sync lock is on. It should be tested with three sync lock groups, and labels before, at and after the selection point, with the label track both selected and unselected when pasting. My first attempt at a fix would modify label tracks in other sync lock groups as well as the label track(s) [note the possible plural] in the sync lock group being modified.
(In reply to James Crook from comment #3) testing on W10 with Audacity 2.4.2 b5e0565 This does NOT fix the steps to reproduce I still get the split label with the unlabelled 30 seconds in the middle So marking as REOPENED
Dang. It's fixed for paste, but not for generate. Working on it.
(In reply to James Crook from comment #5) I'm not sure it's "fixed for paste" either. What happens with paste is that the label remains a single label but it is not extended by the length of the pasted audio. So that means that some audio previously carefully labelled by the user is no longer labelled.
(In reply to Peter Sampson from comment #6) IGNORE Comment #6 I forgot to turn on sync-lock <blushes deeply>
I should be blushing for not trying all the steps. DEVEL - FIX MADE https://github.com/audacity/audacity/commit/9d5befc196f08fe7c314136e7007d8929829551e
(In reply to James Crook from comment #8) Testing on W10 with Audacity 2.4.2 9d5befc1 The Steps to reproduce work with both Generate and cut/copy and paste. I will do further testing around as outlined in James' Comment #3 later.
Created attachment 986 [details] 3 SLTGs for testing Bug 2408 Attached is an image of the three STLGs I set up for testing as per James's request. I tried adding a Chirp (and a paste) in each of the three "Test-x" labelled sections - all seemed fine where only the actual STLG that was being added to got affected, the other two SLTGs remained untouched. With multiple tracks in an SLTG when you generate a chirp in one track the other track(s) in that SLTG get a silence inserted for the duration of the chirp. But that is what I would expect in order to retain synchronization in that SLTG (silence of blank space is what I would expect). You can see an example of this in the attachment with the second SLTG. Looking good on Windows. =========================================================== In the process I have uncovered a selection bug 1) click cursor in a track in SLTG-1 2) click a label in the label track in SLG-2 3) Observe: the label is created for the duration of the step 2 label - but the selection is wrongly in SLTG-1 I will be logging this. It caught me out a lot, and confused me, when I was doing this SLTG testing
Fore safety's sake I also tested this on Mac - all looks good there too
(In reply to Peter Sampson from comment #10) >In the process I have uncovered a selection bug >1) click cursor in a track in SLTG-1 >2) click a label in the label track in SLG-2 >3) Observe: the label is created for the duration of the step 2 label - but the >selection is wrongly in SLTG-1 > >I will be logging this. Logged as P2 Bug #2461
