Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2418 - Time toolbar displays incorrect time if project rate isn't 44100
Time toolbar displays incorrect time if project rate isn't 44100
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.4.0
Per OS All
: P2 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-04 00:50 UTC by Leland Lucius
Modified: 2020-06-07 11:52 UTC (History)
4 users (show)

See Also:
Steps To Reproduce:
1) Start Auacity 2) Set Project Rate to 44100 3) Set Selection toolbar time format to Samples 4) Set Time toolbar time format to Samples 5) Generate 30 second chirp 6) Click at the 10 second (or so) mark 7) Observe: the Selection and Time toolbars display the same number of samples. 8) Change Project Rate to 48000 9) Observe: the sample counts no longer match. The "Time" toolbar assumes that the sample rate is 44100.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2020-06-07 00:00:00
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+
stevethefiddle: Test‑OK‑Lin+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leland Lucius 2020-05-04 00:50:53 UTC
If the project rate isn't 44100 then the Time Toolbar will display the wrong time.
Comment 1 Peter Sampson 2020-05-04 04:57:31 UTC
I confirm Leland's findings on W10 and macOS 10.15.4 with RC05

I tested with a 2 hour chirp ad setting the cursor to 1h 50m or so

The difference is only visible in samples  (or hh:mm:ss + samples) and is only an amount of samples - so looks like some form or rounding error

Curiously if you set the cursor  to an exact number of seconds with zero samples (do this using the selection toolbar and set a label to aid this) then the Selection toolbar and the Time toolbar match.

This is a regression on 2.3.3 where the readings in the Selection toolbar match for selection and time position. 

Because this is a regression and the new big Time toolbar is a key 2.4.0 feature I'm going to rates this as P2
Comment 2 Steve Daulton 2020-05-04 06:32:07 UTC
I don't think this is a bug.

When the time format is set to "samples", that is "number of samples at the current project rate".

I think this is a documentation issue rather than a bug.

Consider the case of multiple tracks selected, where the tracks have different sample rates. In my opinion, the only sensible thing that the Selection Toolbar can show is the "number of samples at the current project rate".

Note that this also affect Generator effects.This looks even more strange than the Selection Toolbar, but imo this is also "not a bug".
Comment 3 Steve Daulton 2020-05-04 06:33:16 UTC
I see the correct time when displayed in anything other than samples.
If anyone sees "seconds" or "h:m:s" incorrectly, then that IS a bug.
Comment 4 David Bailes 2020-05-04 07:22:06 UTC
(In reply to Steve Daulton from comment #2)
> I don't think this is a bug.
> 
> When the time format is set to "samples", that is "number of samples at the
> current project rate".

But the time toolbar is not showing that, it is still showing the number of samples at the original sample rate, whereas the times (in samples) are shown using the current sample rate in the selection toolbar.

See steps to reproduce, step 9.
 
> 
> I think this is a documentation issue rather than a bug.
> 
> Consider the case of multiple tracks selected, where the tracks have
> different sample rates. In my opinion, the only sensible thing that the
> Selection Toolbar can show is the "number of samples at the current project
> rate".
> 
> Note that this also affect Generator effects.This looks even more strange
> than the Selection Toolbar, but imo this is also "not a bug".
Comment 5 Steve Daulton 2020-05-04 07:41:58 UTC
(In reply to David Bailes from comment #4)
Thanks David, I misunderstood. I agree this is a bug. The Time toolbar should behave the same as the other time widgets in the Selection toolbar and time widgets in Generate effects.

I've updated step 9 for clarity.
Comment 6 Leland Lucius 2020-05-31 04:23:49 UTC
Fix in:

https://github.com/audacity/audacity/commit/c43c757
Comment 7 Peter Sampson 2020-05-31 06:36:02 UTC
Testing on W10 with Audacity 2.4.2 b5e0565

At Step 9 the sample counts match
Comment 8 Peter Sampson 2020-05-31 06:37:42 UTC
(In reply to Leland Lucius from comment #6)
Testing on macOS 10.15.5 Catalina with Audacity 2.4.2 b5e0565

At Step 9 the sample counts match
Comment 9 Steve Daulton 2020-06-07 11:52:16 UTC
Works for me on Linux.