Bug 2419 – Time toolbar: Opening and closing preferences resets format to hh:mm:ss

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2419 - Time toolbar: Opening and closing preferences resets format to hh:mm:ss


Summary:	Time toolbar: Opening and closing preferences resets format to hh:mm:ss

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.4.0
Hardware:	Per OS All

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-05-04 08:34 UTC by David Bailes
Modified:	2020-06-07 11:46 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1. Set the format of the time toolbar to anything other than hh:mm:ss. 2. Open preferences, and press OK button. 3. Observer that the format of the time toolbar has be reset to hh:mm:ss.
Release Note:	Group: Toolbars *Closing any Preferences dialog will cause the time format of the Time toolbar to revert to its defauly hh:mm:ss setting
First Git SHA:
Group:	---
Workaround:	Reset the the time format in the Time toolbar to your preferred setting after using Preferences.
Closed:	2020-06-07 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ flyer185: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Bailes 2020-05-04 08:34:38 UTC

See steps to reproduce.

I've left setting the priority at default - QA may well want to change this.

Comment 1 Peter Sampson 2020-05-04 08:54:03 UTC

I have upgraded this to P2 as
a) it is a sort of regression -the Audio position in the old Selection toolbar was not similarly affected
b) the big Time toolbar is one of our key new features for 2.4.0

Good catch David

Comment 2 Peter Sampson 2020-05-04 08:56:52 UTC

Also fails on macOS 10.15.4 with RC05 - so assume all platforms

Comment 3 Cliff Scott 2020-05-29 22:36:40 UTC

Note it also resets the size as well as the format.

Comment 4 Leland Lucius 2020-05-30 17:03:25 UTC

Fixed in:

https://github.com/audacity/audacity/commit/7ac58ac
https://github.com/audacity/audacity/actions/runs/120133382

Comment 5 Cliff Scott 2020-05-30 23:23:43 UTC

MacOS Mojave, Commit: 7ac58a Test good. No resetting of the time toolbar when closing Preferences with the OK button.

Comment 6 Peter Sampson 2020-05-31 04:20:47 UTC

(In reply to Leland Lucius from comment #4)
Testing on W10 and macOS 10.15.5 Catalina - with Audacity 2.4.2 419e152

Tests OK. No resetting of the Time toolbar when closing Preferences with the OK button.

Comment 7 Steve Daulton 2020-06-07 11:46:55 UTC

I'm not able to reproduce this issue on Linux in 2.4.0, 2.4.1 or 2.4.2.
As it  has tested OK on other platforms, I'm closing as Fixed.