Bug 2445 – Cryptic, unhelpful, error message when importing malformed MP3 file

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2445 - Cryptic, unhelpful, error message when importing malformed MP3 file


Summary:	Cryptic, unhelpful, error message when importing malformed MP3 file

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.4.2
Hardware:	Per OS All

Importance:	P3 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Duplicates:	2444 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-05-24 06:45 UTC by Peter Sampson
Modified:	2020-08-10 05:41 UTC (History)
CC List:	7 users (show)

See Also:	421
Steps To Reproduce:	1) rename a WAV file to have an MP3 extension 2) Import that file into Audacity 3) Observe: Cryptic, unhelpful, error message
Release Note:	Group: Imports/Exports *When importing malformed MP3 file the following cryptic, unhelpful, error message appears: "MP3 Decoding failed -forbidden bit allocation value".
First Git SHA:
Group:	---
Workaround:	None
Closed:	2020-08-10 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+

Attachments
Cryptic error message (26.33 KB, image/png) 2020-05-24 06:45 UTC, Peter Sampson	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2020-05-24 06:45:36 UTC

Created attachment 976 [details]
Cryptic error message

when importing malformed MP3 file the following cryptic, unhelpful, error message appears:
>MP3 Decoding failed
>forbidden bit allocation value


Just what is the second part this message meant to explain to the average user?

The underlying issue is that they are trying to import an file that is masquerading as am MP3 but is not in fact an MP3 or a properly formulated MP3.  Surely it would be much better if we could tell them that.


This was observed when testing the 2.4.2 fix for Bug #421


Observed on W10 and macOS 10.15.4 so assume all platforms.

Comment 1 Peter Sampson 2020-05-24 07:34:52 UTC

*** Bug 2444 has been marked as a duplicate of this bug. ***

Comment 2 Leland Lucius 2020-08-09 14:26:08 UTC

Fix in:

https://github.com/audacity/audacity/commit/dffa24c

Message now reads:

[Window Title]
Message

[Main Instruction]
Import failed

[Content]
This is likely caused by a malformed MP3.



[OK]

Comment 3 Peter Sampson 2020-08-10 05:37:32 UTC

(In reply to Leland Lucius from comment #2)
Tested on W10 with Audacity 3.0.0 dffa24c

Looks much better with this message - thanks Leland

Comment 4 Peter Sampson 2020-08-10 05:41:26 UTC

(In reply to Leland Lucius from comment #2)
Also tested on macOS 10.15.6 with Audacity 3.0.0 dffa24c

Same improved error message