Bugzilla – Bug 2456
audacity 2.3.3 config with Spectral Selection toolbar corrupts lower dock in 2.4.x and can crash
Last modified: 2020-05-30 09:37:08 UTC
Created attachment 979 [details] 2.3.3 audacity.cfg file This was reported by a user on the Forum. They supplied the carefully worked configuration file they had been using on 2.3.3 (first attachment). When they upgraded to 2.4.1 without a reset they observed that the bottom tooldock toolbars were corrupted with the Spectral Selection toolbar overlaying the Selection toolbar. If you use View toolbars to turn off Selection toolbar at Step 10 then both the Selection Toolbar and the Spectral Selection toolbar disappear. If at Step 10 you turn off the Spectral Selection toolbar the Audacity crashes. If at Step 10 you use Reset Tollbars and then turn on Spectral Selection toolbar all seems to be well. This is not really a regression as prior to 2.4.x we had an integrated Selection toolbar with audio position. Now we have the truncated Selection toolbar and the new Time toolbar. This is an "upgraders" issue.
Created attachment 980 [details] corrupted lower tooldock
Actually, there's nothing real special about the cfg. It's pretty easy to create: 1) Delete existing audacity.cfg 2) Start 2.3.3 3) Show Spectral Selection toolbar 4) Quit Audacity Now, if you start 2.4.x it will crash as soon as you try to hide the Spectral Selection toolbar (plus you get the corruption). I've yet to figure out why though.
Fix in: https://github.com/audacity/audacity/commit/1b5370b https://github.com/audacity/audacity/actions/runs/118734016 One thing you'll notice is that if the user had the Spectral Selection toolbar visible in 2.3.3 and the start 2.4.0, then the new Time toolbar will be shown below the Selection toolbar. If desired, the user can move Time toolbar to the right of the Spectral Selection toolbar. Otherwise, the new Time toolbar will be shown to the right of the Selection toolbar. I think this is an acceptable compromise.
(In reply to Leland Lucius from comment #3) Testing on W10 with Audacity 2.4.2 ef98e5d using Leland's simplified steps from Comment #2 (and thanks for that clarification and simplification os steps to reproduce Leland). Sadly I still get: a) the Spectral Selection Toolbar overlaying and corrupting the Selection toolbar b) the crash when I try to hide the Spectral Selection toolbar. So reopening this one
(In reply to Leland Lucius from comment #3) Testing on macOS 10.15.5 with Audacity 2.4.2 ef98e5d I get the same corruption of the bottom tooldock and the same crash. But the crash is worse on Mac as it sends me into a spinning beach-ball-of-death from which I can't even force quit - I have to reboot the Mac !
Created attachment 985 [details] Toolbars after fix That's odd. I've attached what I get after doing: 1) Delete existing audacity.cfg 2) Start 2.3.3 3) Show Spectral Selection toolbar 4) Quit Audacity 5) Start latest Github Action artifact
Building on MacOS Mojave Commit 5bede6 all seems well. Started from a fresh Audacity config directory. Ran 2.3.3 and added the Spectral Selection Toolbar. Exited from 2.3.3 Started the above build and I got exactly what Leland's attachment showed. Moved the Time tool bar to after the Spectral selection toolbar and all looked just fine. Hid the Spectral Selection toolbar and all was normal. Brought it back up and it just added to the end of the toolbars. No corruption or crashes.
(In reply to Cliff Scott from comment #7) Testing again now with Leland's latest alpha Audacity 2.4.2 5bede69 on macOS 10.15.5 and on W10 this now works properly for me too. I would like to be sure this works properly on Linux too before closing this bug
Works for me on Linux.
