Bug 2459 – Macros with Nyquist effects don't apply saved parameters

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2459 - Macros with Nyquist effects don't apply saved parameters


Summary:	Macros with Nyquist effects don't apply saved parameters

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Nyquist
Version:	2.4.2
Hardware:	Per OS Other

Importance:	P1 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-05-29 19:31 UTC by Paul L
Modified:	2020-06-05 08:18 UTC (History)
CC List:	5 users (show)

See Also:	1807
Steps To Reproduce:	1 Run Audacity 2.3.3, no .cfg files 2 Make a macro that applies only Low-Pass filter 3 Edit frequency parameter to 100 Hz 4 Save the macro 5 Generate default 440 Hz tone 6 Select all and apply the macro Notice how much the tone is attenuated. 7 Run Audacity 2.4.2 8 Generate the same tone and apply the macro 9 Notice less attenuation 10 Also edit the macro, notice you can see 100 in the quoted string for parameters 11 But click to edit the parameters, and the dialog shows 1000 (the default value) instead
Release Note:
First Git SHA:	3653f5f3bf1b6223939053a03ead29d9e9019919
Group:	---
Workaround:
Closed:	2020-06-05 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul L 2020-05-29 19:31:34 UTC

Macros with Nyquist effects do not properly apply their parameters in 2.4.0, and editing parameters in the Macros dialog shows default values instead of the saved values.

I single stepped to see where the parameters are read, and it doesn't happen now except when Nyquist is used for the prompt.

This bug has existed at least since this commit 3653f5f3bf1b6223939053a03ead29d9e9019919 by Leland

"  Bug 1807 - NyquistPrompt Scripting command is not functional
    
    Try #3, but I'm pretty sure this is the one.  :-)"

I have not bisected more exactly yet.

Comment 1 Leland Lucius 2020-06-02 15:53:08 UTC

I've got it James "I think".  Unless you have a for sure fix, I was just fixing to send out my changes to Steve for further testing.  Would you like to give it a try?

Comment 2 Leland Lucius 2020-06-03 10:58:29 UTC

Fix for this was included in:

https://github.com/audacity/audacity/commit/296a9a2

Comment 3 Peter Sampson 2020-06-04 09:24:42 UTC

(In reply to Leland Lucius from comment #2)
Testing on W10 and macOS 10.15.5 with Audacity 2.4.2 815e655

On both platforms the attenuation achieved in 2.4.2 looks the same as in 2.3.3

Step 10 yes it shows 100 Hz when in 2.4.2

Step 11 on editing the command it still properly shows 100 Hz

Comment 4 Steve Daulton 2020-06-05 08:18:29 UTC

Works for me on Linux.