Bug 2478 – Windows: with an empty rules list in "Extended Import" prefs - Tab or Home crashes Audacity

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2478 - Windows: with an empty rules list in "Extended Import" prefs - Tab or Home crashes Audacity


Summary:	Windows: with an empty rules list in "Extended Import" prefs - Tab or Home cr...

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	2.4.2
Hardware:	PC Windows 10

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-06-14 09:08 UTC by Peter Sampson
Modified:	2020-06-22 08:29 UTC (History)
CC List:	9 users (show)

See Also:	442 1512 2490
Steps To Reproduce:	1) clear the audacity settings folder 2) launch Audacity 3) Edit > Preferences > Extended Import 4) Tab - takes you to "Attempt to use filter ..." 5) Tab - takes you to the empty "File extensions" list (with not much of a visual cue) 6.1) Tab - to attempt to move to the buttons - or 6.2) Home (or Ctrl+Home) - which would normally take you to the top of the list 7) Observe: Audacity crashes
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2020-06-16 00:00:00

Flags:	petersampsonaudacity: Accessibility+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2020-06-14 09:08:57 UTC

On Windows with an empty rules list in "Extended Import" preferences - using Tab or Home, when in the table for the list of rules, crashes Audacity.

Note that an empty list is the default state for Audacity - and note that once the table has been populated with at least one rule then the crash does not subsequently occur.

This is not a regression - this goes all the way back to 2.0.0 which is when we introduced the preferences pane foe "Extended Import".

This does not occur on Mac or Linux.


See also Bug #1512 and Bug #442 (both FIXED and closed)
which may be close cousins, or distant relatives at least.

Comment 1 Leland Lucius 2020-06-15 09:57:04 UTC

Fix in:

https://github.com/audacity/audacity/commit/e7e27aa

Comment 2 Peter Sampson 2020-06-15 10:40:16 UTC

Testing on W10 with Audacity 2.4.2 e7e27aa

1) an improvement as step 6.1 tabbing through now works OK

2) But Step 6.2 using Home or Ctrl+Home still crashes Audacity

Comment 3 Leland Lucius 2020-06-15 14:09:11 UTC

(In reply to Peter Sampson from comment #2)
> Testing on W10 with Audacity 2.4.2 e7e27aa
> 
> 1) an improvement as step 6.1 tabbing through now works OK
> 
> 2) But Step 6.2 using Home or Ctrl+Home still crashes Audacity

I can't get 6.2 to crash.  What am I doing wrong?

Comment 4 Peter Sampson 2020-06-15 14:13:35 UTC

(In reply to Leland Lucius from comment #3)
>I can't get 6.2 to crash.  What am I doing wrong?

Extended Import Prefs
Tab, Tab, Home
=> Crash (consistent every time)

Comment 5 Leland Lucius 2020-06-15 14:43:59 UTC

(In reply to Peter Sampson from comment #4)
> (In reply to Leland Lucius from comment #3)
> >I can't get 6.2 to crash.  What am I doing wrong?
> 
> Extended Import Prefs
> Tab, Tab, Home
> => Crash (consistent every time)

How in Hades did I miss that?!?!?!  I've been tabbing and homing like crazy and never hit it.  Looking at it...

Comment 6 Leland Lucius 2020-06-15 17:00:02 UTC

(In reply to Leland Lucius from comment #5)
> (In reply to Peter Sampson from comment #4)
> > (In reply to Leland Lucius from comment #3)
> > >I can't get 6.2 to crash.  What am I doing wrong?
> > 
> > Extended Import Prefs
> > Tab, Tab, Home
> > => Crash (consistent every time)
> 
> How in Hades did I miss that?!?!?!  I've been tabbing and homing like crazy
> and never hit it.  Looking at it...

This was a bug in wxWidgets and was fixed in:

https://github.com/wxWidgets/wxWidgets/pull/1719

I've applied it to our wxWidgets version, but since this doesn't trigger a build, I fixed the off-by-one check reported by Henric Jungheim to force a new Audacity build.  The build can be found here:

https://github.com/audacity/audacity/actions/runs/136439980

Comment 7 Peter Sampson 2020-06-16 05:17:01 UTC

(In reply to Leland Lucius from comment #6)
Testing on W10 with Audacity 2.4.2 456177a

this now works fine - the Home key (and Ctrl+Home) when used in the empty list no longer causes the crash