Bug 2480 – Vertical Scale dB does not update when Meter range is changed in Prefs

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2480 - Vertical Scale dB does not update when Meter range is changed in Prefs


Summary:	Vertical Scale dB does not update when Meter range is changed in Prefs

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.4.2
Hardware:	Per OS All

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-06-15 07:42 UTC by Peter Sampson
Modified:	2020-10-10 12:28 UTC (History)
CC List:	7 users (show)

See Also:	2555 2554
Steps To Reproduce:	1) clear the audacity settings folder 2) get some audio 3) set display to Waveform dB 4) Edit > Preferences > Interface 5) change the "Meter dB range" 6) Press OK 7) Observe: the meters change 8) Observe: the Vertical Scale does not change
Release Note:	Group: User Interface *With a track or tracks are in Waveform dB view and you use Preferences to change the Waveform range, the meters change on exiting prefs but the Vertical Scale(s) do not. Nor do any new tracks added in Waveform dB view.
First Git SHA:
Group:	---
Workaround:	Close Audacity and relaunch it
Closed:	2020-08-20 00:00:00

Flags:	petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2020-06-15 07:42:02 UTC

With a track or tracks are in Waveform dB view and you use Preferences to change the Waveform range, the meters change on exiting prefs but the Vertical Scale(s) do not.

In order to view the change you need to exit Audacity and relaunch.

This is a regression on 2.1.1 - hence the P2 rating.



Additionally if you record a new tack or import a track in dB view the Vertical scale is not updated.  This bit is a regression on 2.3.3

This issue was originally reported on the Forum by user mafg1953
https://forum.audacityteam.org/viewtopic.php?f=46&t=111519&p=397686


Tested 2.4 and 2.4.2 alpha on Mac and Win - regression testing done on Win only.

Comment 1 Leland Lucius 2020-08-09 03:43:32 UTC

Fix in:

https://github.com/audacity/audacity/commit/238bb95

Also fixes spectrogram view

Comment 2 Peter Sampson 2020-08-09 05:52:10 UTC

(In reply to Leland Lucius from comment #1)
Testing on W10 with Audacity 3.0.0 58adb94

The meters and the vertical scale now properly change.

Comment 3 Peter Sampson 2020-08-09 07:19:20 UTC

(In reply to Leland Lucius from comment #1)
Testing on macOS 10.15.67 Catalina with Audacity 3.0.0 58adb94

The meters and the vertical scale now properly change.

Comment 4 Steve Daulton 2020-08-20 06:30:44 UTC

Works for me on Linux.

Comment 5 Paul L 2020-10-10 11:34:36 UTC

I'm requesting re-testing after commit 57b39ed099277e93c60af561e148bb089c254a70 where I made other changes after reviewing the first fix.

Also my recent fix of bug 2555 involved some re-writing of what was done to fix this bug and caused that other bug.

Comment 6 Peter Sampson 2020-10-10 11:43:21 UTC

(In reply to Paul L from comment #5)
I already retested this earlier today on both W10 and macOS 10.15.6 when I was testing your fix for Bug #2555.

BUT In the interests of absolute thoroughness I retested on W10 and on macOS 10.15.7 (my Mac was updated in the meantime)

And on both platforms thus still works fine.

Comment 7 Peter Sampson 2020-10-10 12:25:55 UTC

And tested again on W10 with latest alpha Audacity 3.0.0 57b39ed

All still fine on W10

Comment 8 Peter Sampson 2020-10-10 12:28:39 UTC

And tested again on macOS 10.15.7 with latest alpha Audacity 3.0.0 57b39ed

All still fine on Mac too