Bug 2492 – Linux: Crash when applying or previewing Sliding Stretch effect on stereo track

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2492 - Linux: Crash when applying or previewing Sliding Stretch effect on stereo track


Summary:	Linux: Crash when applying or previewing Sliding Stretch effect on stereo track

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.4.2
Hardware:	Per OS Linux

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-06-26 17:12 UTC by Steve Daulton
Modified:	2020-08-06 07:36 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1. Apply "Sliding Stretch" effect to a stereo track. 2. Observe crash.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2020-08-06 00:00:00

Flags:	stevethefiddle: Must‑Test‑All‑OS+ stevethefiddle: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Backtrace (8.27 KB, text/plain) 2020-06-27 07:52 UTC, Steve Daulton	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2020-06-26 17:12:54 UTC

Audacity crashes when  applying or previewing Sliding Stretch effect to a stereo track.

Bug appears in all 2.4.x.
Regression against Audacity 2.3.3.

Comment 1 James Crook 2020-06-26 17:21:50 UTC

No crash on Windows, so RepeatableAll -> Repeatable.

Comment 2 Peter Sampson 2020-06-27 05:55:37 UTC

Tested on 2.4.2 on W10 and macOS 10.15.5

tested with both stereo and mono tracks - Sliding Stretch works fine in both preview and application.

Comment 3 Steve Daulton 2020-06-27 07:52:46 UTC

Created attachment 999 [details]
Backtrace

Backtrace attached.

Comment 4 Leland Lucius 2020-08-06 02:07:55 UTC

When I implemented CMake, I enabled the MULTITHREAD symbol for SBSMS.  I didn't realize it wasn't enable before.  So, we were exercising "new" code.  Problem was easy to fix and I'm inclined to leave MULTITHREAD defined because it cuts processing time in half on my Linux setup.

In 3.0.0, it takes 1:12 to process a 30 minute chirp with MULTITHREAD disabled and with it enabled it only takes 31 seconds.

Comment 5 James Crook 2020-08-06 04:18:56 UTC

DEVEL - FIX MADE (by Leland)
https://github.com/audacity/audacity/commit/72032d6a2afdafc1e0d811a85fabfd25780bba91

Comment 6 Steve Daulton 2020-08-06 07:36:58 UTC

(In reply to James Crook from comment #5)
Works for me, and as Leland wrote, twice as fast on stereo tracks as 2.3.3 (nice :-)