Bug 2493 – No command for setting Multi-view

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2493 - No command for setting Multi-view


Summary:	No command for setting Multi-view

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Other
Version:	2.4.2
Hardware:	Per OS All

Importance:	P3 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-06-27 08:22 UTC by Steve Daulton
Modified:	2020-09-11 07:40 UTC (History)
CC List:	6 users (show)

See Also:	2460
Steps To Reproduce:	1. Create a Macro to change the view of the current track to "Multi-view" 2. Observer that there is no way to do so.
Release Note:	Scripting: Track Multi-view is not supported by scripting commands.
First Git SHA:
Group:	---
Workaround:
Closed:	2020-09-10 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS- stevethefiddle: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2020-06-27 08:22:41 UTC

In 2.3.3 you could change the track view to any supported view (Waveform / Waveform (dB) / Spectrogram) with the "Set Track Visuals" command. Example:
  SetTrackVisuals:Display="Waveform" Scale="dB"

If that command is saved as a Macro, then you can set a keyboard shortcut for it.

Now we have "Multi-View" but no scripting / Macro command to enable (or disable) it.

It is "possible" to enable / disable Multi-view from the keyboard (using the track context menu, cursor keys and Enter), but you can't set a keyboard shortcut.

(It would also be nice to be able to "get" the current view without having to resort to Nyquist)

Comment 1 James Crook 2020-09-10 09:45:23 UTC

DEVEL-FIX MADE
https://github.com/audacity/audacity/commit/7e573b9b2ffa4dd013bf965bc79755a314db258a

Comment 2 Peter Sampson 2020-09-10 12:01:37 UTC

In the Macro command "Set Track" the "Display" drop-down offers "Multi-view"

Comment 3 Peter Sampson 2020-09-10 12:04:02 UTC

>In the Macro command "Set Track" the "Display" drop-down offers "Multi-view"

testing on W10 and macOS 10.15.6 with Audacity 3.0.0 f06b9a9

This is true on both plaforms

Comment 4 Paul L 2020-09-10 13:26:52 UTC

Author of the feature has objections to the implementation.

This needs review and rework to avoid "magic numbers."

Comment 5 Paul L 2020-09-10 13:45:18 UTC

Strong objections to this fix.

"Multi-view" is not to be treated as another type of view.  Rather it requests that one of each kind of view be shown.

A track (really a view of a track, not the same thing) no longer has view type as a single property.  There must be a list of the types of sub-views that are shown if there is more than one view, and "Multi-view" will not be another atom to put into that list.

See Nyquist.cpp around line 1130 where 'VIEW property is computed.

Comment 6 Paul L 2020-09-10 15:34:39 UTC

Reimplemented at https://github.com/audacity/audacity/commit/c7896a36564da05907a3f6603cb3e7c68ade6d49

Please re-test.

Comment 7 Peter Sampson 2020-09-11 07:40:25 UTC

(In reply to Paul L from comment #6)
Tested on W10 with Audacity 3.0.0 c7896a3

This still works