Bug 2496 – Label edit typing prepends selected text rather than replacing it

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2496 - Label edit typing prepends selected text rather than replacing it


Summary:	Label edit typing prepends selected text rather than replacing it

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.4.2
Hardware:	All All

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-06-29 08:20 UTC by Peter Sampson
Modified:	2020-08-18 16:00 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1) create a label with some text 2) select all or some of the label text 3) type new text 4) Observe: the new text pre-pends the selected text (should replace it)
Release Note:	Group: Labels *When editing a label (in the label itself) typing prepends selected text rather than replacing it.
First Git SHA:
Group:	---
Workaround:	To replace text in a label, click ad drag to select the text, delete the text, then type the new text.
Closed:	2020-08-18 00:00:00

Flags:	petersampsonaudacity: Quickfix‑Requested+ petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2020-06-29 08:20:13 UTC

When editing a label (in the label itself) typing prepends selected text rather than replacing it.  

This only affects in-label editing, the Edit>Labels dialog is not afflicted by this.

Originally reported by Bill on Mac - fails for me on W10 with 2.4.2 so assume all platforms.

This is a regression on 2.3.2 - hence the P2 rating.

Comment 1 David Bailes 2020-07-10 05:45:39 UTC

Fixed at:
https://github.com/audacity/audacity/commit/975ee0cc0714e8cb533994a8e6a52570e24e7388

Only needs testing on one platform.

Comment 2 Peter Sampson 2020-07-10 07:35:42 UTC

(In reply to David Bailes from comment #1)
Testing on W10 with Audacity 3.0.0 975ee0c

This looks to be properly fixed and working on Windows

Comment 3 Peter Sampson 2020-07-10 07:41:50 UTC

(In reply to David Bailes from comment #1)
Testing on macOS 10.15.5 Catalina with Audacity 3.0.0 975ee0c

This looks to be properly fixed and working on Mac

-----------------------------------------------------

I did discoover an issue on Mac wherby using Undo to try to revert a label edit results in an empty label.

On Win in contrast the original label is properly restored.

I will log this as a new separate issue

Comment 4 Steve Daulton 2020-08-18 16:00:32 UTC

Works for me on Linux.


Peter wrote:
> I did discoover an issue on Mac wherby using Undo to try to revert a label
> edit results in an empty label.
On Linux, the previous label text is properly restored.