Bug 2500 – "EQ XML to TXT Converter" fails on CRLF line endings

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2500 - "EQ XML to TXT Converter" fails on CRLF line endings


Summary:	"EQ XML to TXT Converter" fails on CRLF line endings

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Nyquist
Version:	2.4.2
Hardware:	All macOS and Linux

Importance:	P2 Repeatable
Assigned To:	Steve Daulton

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-06-30 14:49 UTC by Steve Daulton
Modified:	2020-08-05 12:55 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1. Download EQ toolbox for 78 rpm shellacs from: https://wiki.audacityteam.org/w/images/a/aa/EQ_toolbox_78rpm.xml 2. Attempt to convert to the new .txt format 3.Observe that the conversion fails.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2020-08-05 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Mac+ james.k.crook: Test‑OK‑Lin+

Attachments
Updated plug-in (5.68 KB, text/plain) 2020-06-30 15:32 UTC, Steve Daulton	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2020-06-30 14:49:10 UTC

Several of the curves provided on the Audacity wiki use CRLF rather than LF. This causes "EQ XML to TXT Converter" to fail.

Tested on Linux and macOS.
This may not be a problem on Windows, I've not tested.

Comment 1 Steve Daulton 2020-06-30 15:32:16 UTC

Created attachment 1000 [details]
Updated plug-in

This fixes it on Linux.
Not yet tested on Mac or Windows.

Comment 2 Steve Daulton 2020-07-01 19:56:07 UTC

Fixed at 
https://github.com/audacity/audacity/commit/e7fd679


I think it is adequate to just test on Windows and Mac.
On Mac, it should fix the bug.
The bug did not appear on Windows, so the plug-in should still work.

Comment 3 James Crook 2020-07-02 05:14:29 UTC

Re comment #2
I want it tested on all platforms before closing.  So I added flag must-tes-all-os

Comment 4 Steve Daulton 2020-07-02 05:45:54 UTC

(In reply to James Crook from comment #3)
As we have so few testers on Linux, would you test it on Linux James please.

Comment 5 Peter Sampson 2020-07-02 08:38:45 UTC

(In reply to Steve Daulton from comment #2)
Testing on W10 with Audacity 3.0.0 e7fd679

I can successfully use the converter and I can import and use the curves that get downloaded.

Comment 6 Peter Sampson 2020-07-02 08:45:39 UTC

(In reply to Steve Daulton from comment #2)
Testing on macOS 10.15.5 Catalina with Audacity 3.0.0 e7fd679

I can successfully use the converter and I can import and use the curves that get downloaded.

Comment 7 Peter Sampson 2020-07-02 08:48:00 UTC

(In reply to Steve Daulton from comment #2)
Testing on macOS 10.15.5 Catalina with Audacity 3.0.0 e7fd679

I can successfully use the converter and I can import and use the curves that get downloaded.

Comment 8 James Crook 2020-08-05 12:55:55 UTC

Tested on Linux too.  Works fine.
RESOLVED FIXED