Bugzilla – Bug 2509
Filter curve and Graphic EQ help links are broken in release version
Last modified: 2020-07-28 07:29:06 UTC
The help buttons for "Graphic EQ" and "Filter Curve EQ" give "404" error. Note that this only happens in the release build, not alpha or beta builds. In other words, the problem occurs when linking to the release manual, but not when linking to the alpha manual. Reported: https://github.com/audacity/audacity/issues/633 Initially marked as P2 as this bug is most likely to affect users that need to use the feature. This appears to be due to the incorrect use of spaces in the help links rather than underscores. Allocated to myself. I'll do a few tests, and hopefully commit a fix later today.
Testing on W10 and macOS 10.15.6 with Audacity 3.0.0 09f7aaa On 3.0.0 alpha these links appear to work. But here they are going to the on-line Manual as the Manual is not installed with alpha builds
(In reply to Peter Sampson from comment #1) Yes, links to the alpha manual work. It's links to the release manual (for these two new effects) that don't work. The bug should be reproducible in the release version of Audacity 2.4.2.
(In reply to Steve Daulton from comment #2) >The bug should be reproducible in the release version of Audacity 2.4.2. Yes I can reproduce thiis on 2.4.2 on Mac and Win. I'm just puzzled why it works on 3.0.0 (with the offline Manual) with no apparent "fix" made
(In reply to Peter Sampson from comment #3) > I'm just puzzled why it works on 3.0.0 (with the offline Manual) > with no apparent "fix" made It also works in an alpha build of Audacity 2.4.2.
It has never worked in release builds since we introduced Graphic EQ and Filter Curve in 2.3.3 and onwards 2.4.x It did work in the old Equalization in 2.3.2 What is odd is that I can distinctly remember testing those help button in the alpha build in 2.3.3 and they worked in the alpha.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/dad27f9eea01c32deed8c0944ccecb6fb14907fa Fixed by using _ and not space in the effect names. Note that this code below also looks a little suspect. Could also have fixed it here. Steve added this code, perhaps to do something with Nyquist effects?? Steve, any comments? // Replace spaces with "+" releasePageName.Replace(wxT(" "), wxT("+"), true);
(In reply to James Crook from comment #6) > Steve added this code, perhaps to do something with Nyquist effects?? Yes, that's why I allocated this bug to myself - so that I could consider changing that, but as bug 2509 is now fixed I'll leave it as is.
