Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2513 - Importing a file into a disk that is nearly full gives unhelpful error message
Importing a file into a disk that is nearly full gives unhelpful error message
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Application Core
3.0.0
All All
: P2 RepeatableAll
Assigned To: Paul L
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-02 11:02 UTC by Peter Sampson
Modified: 2020-09-05 05:49 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
Testing on W10 using a small USB stick with an estimated 2 minutes recording time space remaining (As shown in Status bar) 1)Import a file that is longer than the 2 spare space minutes 2) Observe:error message "Failed to add sample block"
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2020-09-05 00:00:00
petersampsonaudacity: Quickfix‑Requested+
petersampsonaudacity: Regression+
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Sampson 2020-08-02 11:02:57 UTC
Importing a file into a disk that is nearly full (a file to large for the remaining available space) gives unhelpful error message:
>"Failed to add sample block"

And the disk is left totally filled

Setting this to P2 but it is marginal P1


This is a regression on 2.4.2 and earlier where we had a proper error trap abd this helpful error message:
>Audacity failed to write to a file
>Perhaps G: is not writable or the disk is full

And in this case the space on disk is reclaimed with the project wound back to how it was before the aborted/failed import
Comment 1 Peter Sampson 2020-08-02 11:04:08 UTC
This is also logged as as part of UP-25
https://wiki.audacityteam.org/wiki/Unitary_Project_-_issue_tracking#up25

I have assigned to Paul as he volunteered to fix the UP-25 issues
Comment 2 Paul L 2020-08-26 17:04:53 UTC
At https://github.com/audacity/audacity/commit/2389b191f637e60a0d025b46b9735dd7ee1ddc77

The error message is made more helpful, but that is not the entire complaint?
Comment 3 Paul L 2020-08-26 17:14:57 UTC
If part of the complaint is non-reclamation of disk space -- is the vacuuming on exit enough?

Or maybe you find that vacuuming fails,  because it requires sufficient space on the drive for a copy?
Comment 4 Peter Sampson 2020-08-27 06:11:34 UTC
Testing on W10 with Audacity 3.0.0 70175ac - latest Master alpha

This appears to be back to 2.4.2 behavior (not entirely perfect - but graceful, informative and can be dealt with)

Following the Steps to reproduce

At Step 2 I get the error message
>Audacity failed to write to a file
>Perhaps G: is not writable or the disk is full

This is a much better error messaged and is I believe the same as we had in 2.4.2
So I am going to mark this as OK on Windows.


Paul wrote:
>The error message is made more helpful, but that is not the entire complaint?
That was the "complaint" of this bug

>If part of the complaint is non-reclamation of disk space -- 
>is the vacuuming on exit enough?
>
>Or maybe you find that vacuuming fails,  because it requires sufficient 
>space on the drive for a copy?

This would be a separate issue, as yet unlogged, and currently under discussion
Comment 5 Peter Sampson 2020-08-27 07:43:40 UTC
Testing on macOS 10.15.6 Catalina with Audacity 3.0.0 70175ac latest Master alpha

This appears to be back to 2.4.2 behavior 

Following the Steps to reproduce

At Step 2 I now get the error message that we used to get in 2.4.2 (and some earlier)
>Audacity failed to write to a file
>Perhaps /Volumes/NO NAME/ is not writable or the 
>disk is full

I shall mark this as OK on Mac