Bugzilla – Bug 2534
Change Speed merges selected clip with adjacent clips
Last modified: 2021-01-28 15:56:07 UTC
When applying Change Speed effect to a clip that butts up to another clip (a split line between the clips but no gap), the split is removed and selected clip becomes joined to adjacent clips. Tested on Linux.
Fix committed in 5bca69c that addresses the SoundTouch mode of ChangePitch and ChangeTempo. It'd be great if this could be tested to ensure what I've done is working properly while I work on the SBSMS mode. Testing on one platform is fine and you'll want to test as many combinations of splits and time shifted tracks as you can think of.
This looks good to me. There's slight peculiarities if the channels of a stereo track have splits at different times, but that is in itself quite peculiar and the result does not look "wrong". I think this is good to go, though I'd appreciate a second opinion as there are quite a lot of possible fringe cases and I'm not sure that I've covered all of them. @Leland, I assume this bug was fixed here: https://github.com/audacity/audacity/commit/5bca69c
What's supposed to happen with white space between audio clips? I think it should be the same as https://bugzilla.audacityteam.org/show_bug.cgi?id=1215#c1 Currently white space is rendered as silence.
(In reply to Steve Daulton from comment #3) Testing on W10 with Audacity 3.0.0 5bca69c This now appears to be fixed on W10 - albeit with the residual of how white spsce is I confirm that white space is converted to silence a) no other effect appears to do that - so no reason for Change Speed to do so. b) It destroys the user's carefully-created clip structure turn a selection which prior to using Change Speed was a set of separate clips into a single consolidated clips c) you even get the nonsense that if you select just white space and apply Change Speed you get silence created there So for me the conversion to silence is s big no-no - and accordingly I'm reopening this for the residual
(In reply to Peter Sampson from comment #4) Also I note d) split-lines are created at the created silence boundaries with the audio
Bummer...it's not supposed to create silence. I added code specifically for that case. What steps are you guys using that produces the silence?
DOH!!!!!!!!!! I'm an idiot! This is for Change!SPEED! not ChangeTempo. Give me a sec...
Created attachment 1006 [details] Bug 2534 silence created by Change Speed See attachment this us the state after applying change speed where I have two clips separated by white space. 1) Observe: silence now between the clips 2) Observe: split lines either side of the silence 2 is different behavior to my initial test where the two clips were fused into a single clip. Now I get three independent clips: the two original clip and the silence which has become a clip in itself
Okay, NOW try this. :-)
So, if this works for you guys, we can close this bug as ChangeSpeed doesn't have an SBSMS mode.
(In reply to Leland Lucius from comment #9) Testing on W10 with Audacity 3.0.0 3605d73 This looks *much* better - works for me now on W10 as it should - and with no silence creation. I'll just leave open for now to give Steve a chance to test it ...
Tested on macOS 10.15.6 with Windows_32bit_c60bf1c Works properly on Mac as well now - no silence created from blank space and the individual clips remain individual clips
This is now much better, but still has some peculiarities. We may want to close this bug and open a new bug for "residuals", though if Leland can resolve the residuals it may make more sense to retain the progress in one bugzilla thread than split over multiple bugs. @Leland, please say if you would prefer to split residuals into separate bugs or deal with them here. Residual issue: 1. Generate 30 second chirp 2. Select from 4 to 6 seconds and "split delete" (Alt + Ctrl + K) 3. Split at 15 seconds. 4. Select 0 to 10 seconds 5. "Change Speed" with % change = 100 Expected result: * First clip shrinks from 4 seconds to 2 seconds. * Gap after first clip shrinks from 2 seconds to 1 second. * Selection shrinks from 10 seconds to 5 seconds. * Split line moves from 15 seconds to 10 seconds. Actual result: All of the "expected results" occur, but there is also an addition split added at 7.5 seconds !?!
(In reply to Steve Daulton from comment #13) In my previous post, step 2 (Select from 4 to 6 seconds and "split delete") is unnecessary.
(In reply to Steve Daulton from comment #13) > Actual result: > All of the "expected results" occur, but there is also an addition split > added at 7.5 seconds !?! Yep, see what you mean. Looking into it.
Reopened in the light of comment #13.
Let see if this fixes the residual: https://github.com/audacity/audacity/commit/dd58db4 Also, you might want to reverify the original problem and any other combinations you might dream up.
Created attachment 1067 [details] Bug 2534 residual test result (In reply to Leland Lucius from comment #17) Testing the fix for the residual on W10 with Audacity 3.0.0 058023f This now works properly - see attachment for result
(In reply to Leland Lucius from comment #17) Also retested the original steps on W10 with Audacity 3.0.0 058023f This continues to work fine
(In reply to Leland Lucius from comment #17) Tested the residual fix on macOS 11.1 Bug Sur with Audacity 3.0.0 058023f As on Windows this now works properly Also retested the original steps on W10 with Audacity 3.0.0 058023f all fine still
Examining the commit for this fix clearly shows that the fix is clearly not platform-specific: https://github.com/audacity/audacity/commit/dd58db409752b66dd5331ba60472e03c5a3e5226 So as this and now its residual test OK on Win and Mac I shall close this as FIXED
